This repository was archived by the owner on Jan 23, 2024. It is now read-only.
skip file rather than exit when a yaml file with no melange package n…#6
Open
rawlingsj wants to merge 1 commit intowolfi-dev:mainfrom
Open
skip file rather than exit when a yaml file with no melange package n…#6rawlingsj wants to merge 1 commit intowolfi-dev:mainfrom
rawlingsj wants to merge 1 commit intowolfi-dev:mainfrom
Conversation
…ame found noticed this when running dag in a folder that had other yaml files which were not melange configs, so wanted dag to ignore these files. Signed-off-by: James Rawlings <jrawlings@chainguard.dev>
luhring
approved these changes
Nov 9, 2022
| name := c.Package.Name | ||
| if name == "" { | ||
| log.Fatalf("no package name in %q", path) | ||
| log.Printf("no package name in %q", path) |
Member
There was a problem hiding this comment.
nit: (just to be explicit about the effect this circumstance will have on the DAG) 🤷
Suggested change
| log.Printf("no package name in %q", path) | |
| log.Printf("no package name in %q, skipping...", path) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ame found
noticed this when running dag in a folder that had other yaml files which were not melange configs, so wanted dag to ignore these files.
Signed-off-by: James Rawlings jrawlings@chainguard.dev