Skip to content

dotnet-8: powershell: build separate package dotnet-sdk-8.0.404 to build powershell 7.4.6 #35344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ader1990
Copy link
Contributor

Add dotnet-sdk only package 8.0.404 that is installed alongside 8.0.110.
The SDK 8.0.404 is required to build PowerShell 7.4.6

@xnox xnox force-pushed the dotnet-8-bootstrap-sdk-with-source-80404 branch from e63636c to 5f70a03 Compare November 27, 2024 14:37
@xnox xnox added the approved-to-run A repo member has approved this external contribution label Nov 27, 2024
@@ -0,0 +1,148 @@
package:
name: dotnet-sdk-8-only
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the .yaml filename and the first package name must match. I'm not sure if you wanted this with or without "-only".

Copy link
Contributor Author

@ader1990 ader1990 Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think neither is a good option, as this one builds a specific version of dotnet that has to somehow stay forever there to build the exact version of PowerShell.
Powershell 7.4.6 can be built only with dotnet-sdk-8 v8.0.404 (possible some bigger interval).
What would be a good naming scheme in this case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we require in the build deps a specific version of an apk package? if so, that would be rather easy.

Copy link
Contributor

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-to-run A repo member has approved this external contribution lifecycle/stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants