Skip to content

libmamba/2024.12.12 package update #36620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Dec 12, 2024

@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr labels Dec 12, 2024
Copy link
Contributor Author

octo-sts bot commented Dec 12, 2024

Gen AI suggestions to solve the build error:

Based on the error output, I'll provide a detailed analysis and solution:

• Detected Error:

patching file libmamba/CMakeLists.txt
Hunk #1 FAILED at 445.
1 out of 1 hunk FAILED -- saving rejects to file libmamba/CMakeLists.txt.rej

• Error Category: Configuration/Patch

• Failure Point: Patch application step failing to modify libmamba/CMakeLists.txt

• Root Cause Analysis:
The patch file "support-shared-libs.patch" is not aligning with the current version of the CMakeLists.txt file, likely due to changes in the upstream source between versions.

• Suggested Fix:

  1. Update the patch file to match the new file structure:
    # Generate a new patch against the current source
    git diff --no-prefix libmamba/CMakeLists.txt > support-shared-libs.patch
  2. Alternative approach - modify the CMakeLists.txt directly in the pipeline:
    pipeline:
      - uses: git-checkout
        with:
          expected-commit: 4cbb3f7de08b75a5bffd50fd6b4bb79f0291dd42
          repository: https://github.com/mamba-org/mamba
          tag: ${{package.version}}
      
      - runs: |
          sed -i '/SHARED/! s/add_library(mamba/add_library(mamba SHARED/' libmamba/CMakeLists.txt

• Explanation:
The patch failure occurs because the upstream CMakeLists.txt file has been modified in version 2024.12.12. The patch system expects exact line matches, and when the context doesn't match, it fails. The suggested fix either updates the patch file to match the new source or modifies the file directly using sed.

• Additional Notes:

  • The version 2024.12.12 is very recent, suggesting this is a new release
  • The patch system is strict about exact matches to ensure safety
  • Consider using more robust patching methods for frequently changing upstream sources
  • Monitor upstream changes to CMake configuration for future updates

• References:

@mamccorm
Copy link
Member

patch is failing

@dannf
Copy link
Member

dannf commented Dec 12, 2024

Closing per #36183

@dannf dannf closed this Dec 12, 2024
@octo-sts octo-sts bot deleted the wolfictl-b6651920-9e35-4824-a549-f281f40cfbe0 branch December 13, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated pr request-version-update request for a newer version of a package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants