Skip to content

Fixed brew pkgconf pipeline test failure #40555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fixed brew pkgconf pipeline test failure #40555

wants to merge 4 commits into from

Conversation

priyanshuraj400
Copy link

Fixes:
#34006

Related:
#32554

@priyanshuraj400
Copy link
Author

Hello @dustinkirkland @murraybd,
Raised this PR to fix the ongoing test failure issue for brew package. Please take a look and suggest if changes required.

@priyanshuraj400 priyanshuraj400 force-pushed the brew-pkgconf branch 3 times, most recently from 8fed5e1 to faffabb Compare January 31, 2025 15:21
a-crate
a-crate requested changes Feb 28, 2025
View reviewed changes
brew.yaml Outdated
# Relocate .pc files to /usr/lib/pkgconfig and create symlinks
mkdir -p ${{targets.destdir}}/usr/lib/pkgconfig/
find ${{targets.destdir}}/home/linuxbrew -name "*.pc" | while read pc_file; do
mkdir -p "$(dirname "$pc_file")" && mv "$pc_file" "${{targets.destdir}}/usr/lib/pkgconfig/$(basename "$pc_file")" && ln -s "../../../../../usr/lib/pkgconfig/$(basename "$pc_file")" "$pc_file"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Split this into multiple lines please.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ln -s "../../../../../

👀

brew.yaml Outdated
# Relocate .pc files to /usr/lib/pkgconfig and create symlinks
mkdir -p ${{targets.destdir}}/usr/lib/pkgconfig/
find ${{targets.destdir}}/home/linuxbrew -name "*.pc" | while read pc_file; do
mkdir -p "$(dirname "$pc_file")" && mv "$pc_file" "${{targets.destdir}}/usr/lib/pkgconfig/$(basename "$pc_file")" && ln -s "../../../../../usr/lib/pkgconfig/$(basename "$pc_file")" "$pc_file"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mkdir -p "$(dirname "$pc_file")" seems unnecessary, the file exists so the directory it's in must exist too

brew.yaml Outdated
# Relocate .pc files to /usr/lib/pkgconfig and create symlinks
mkdir -p ${{targets.destdir}}/usr/lib/pkgconfig/
find ${{targets.destdir}}/home/linuxbrew -name "*.pc" | while read pc_file; do
mkdir -p "$(dirname "$pc_file")" && mv "$pc_file" "${{targets.destdir}}/usr/lib/pkgconfig/$(basename "$pc_file")" && ln -s "../../../../../usr/lib/pkgconfig/$(basename "$pc_file")" "$pc_file"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these .pc files are symlinks to existing pkg-config files, don't move those.

brew.yaml Outdated
# Relocate .pc files to /usr/lib/pkgconfig and create symlinks
mkdir -p ${{targets.destdir}}/usr/lib/pkgconfig/
find ${{targets.destdir}}/home/linuxbrew -name "*.pc" | while read pc_file; do
mkdir -p "$(dirname "$pc_file")" && mv "$pc_file" "${{targets.destdir}}/usr/lib/pkgconfig/$(basename "$pc_file")" && ln -s "../../../../../usr/lib/pkgconfig/$(basename "$pc_file")" "$pc_file"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think an absolute symlink would be better here, then it doesn't need to assume the relative folder level

@priyanshuraj400 priyanshuraj400 force-pushed the brew-pkgconf branch 2 times, most recently from 64418df to 4e097b0 Compare March 4, 2025 11:32
@priyanshuraj400
Copy link
Author

Hello @a-crate, @tuananh
I have made the changes suggested by you.

Please proceed.

@priyanshuraj400 priyanshuraj400 changed the title Moved .pc files and added pkgconf test Fixed brew pkgconf pipeline test failure Mar 4, 2025
@priyanshuraj400 priyanshuraj400 mentioned this pull request Mar 5, 2025
Closed
a-crate
a-crate requested changes Mar 7, 2025
View reviewed changes
Copy link
Member

@a-crate a-crate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump brew's epoch as well.

Sorry for delay between reviews on this. Otherwise looks good, thanks.

brew.yaml Outdated
find ${{targets.destdir}}/home/linuxbrew -name "*.pc" | while read pc_file; do
if [ ! -L "$pc_file" ]; then
mv "$pc_file" "${{targets.destdir}}/usr/lib/pkgconfig/$(basename "$pc_file")"
ln -s "${{targets.destdir}}/usr/lib/pkgconfig/$(basename "$pc_file")" "$pc_file"
Copy link
Member

@a-crate a-crate Mar 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link is the wrong way around, link ln -s "$pc_file" "${{targets.destdir}}[...] is the correct order.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @a-crate,
Since we are moving the original .pc files from installation directory to usr/lib/pkgconfig/ and then creating the symlinks at the original place, the syntax seems to be right.
I have also checked and confirmed by running tests.

Let me know if any other changes are required.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I mean that ${{targets.destdir}} is baked into the symlink and it's broken. This is from the package just built by presubmit runs (sorry for wall of text):

6904c42c06d5:~# for i in $(apk info -L brew | grep '.pc$'); do file /$i | grep broken; done
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.10/expat.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/expat.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.10/libcurl.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libcurl.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.10/libedit.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libedit.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.10/libexslt.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libexslt.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.10/libffi.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libffi.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.10/libxml-2.0.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libxml-2.0.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.10/libxslt.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libxslt.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.10/ncurses.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/ncurses.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.10/ncursesw.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/ncursesw.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.10/sqlite3.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/sqlite3.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.10/uuid.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/uuid.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.10/zlib.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/zlib.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.11/bzip2.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/bzip2.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.11/expat.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/expat.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.11/libcurl.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libcurl.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.11/libedit.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libedit.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.11/libexslt.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libexslt.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.11/libffi.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libffi.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.11/libxml-2.0.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libxml-2.0.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.11/libxslt.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libxslt.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.11/ncurses.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/ncurses.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.11/ncursesw.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/ncursesw.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.11/sqlite3.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/sqlite3.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.11/uuid.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/uuid.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.11/zlib.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/zlib.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.12/bzip2.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/bzip2.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.12/expat.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/expat.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.12/libcurl.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libcurl.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.12/libedit.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libedit.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.12/libexslt.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libexslt.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.12/libffi.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libffi.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.12/libxml-2.0.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libxml-2.0.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.12/libxslt.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libxslt.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.12/ncurses.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/ncurses.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.12/ncursesw.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/ncursesw.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.12/sqlite3.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/sqlite3.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.12/uuid.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/uuid.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.12/zlib.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/zlib.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.13/bzip2.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/bzip2.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.13/expat.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/expat.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.13/libcurl.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libcurl.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.13/libedit.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libedit.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.13/libexslt.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libexslt.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.13/libffi.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libffi.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.13/libxml-2.0.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libxml-2.0.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.13/libxslt.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libxslt.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.13/ncurses.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/ncurses.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.13/ncursesw.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/ncursesw.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.13/sqlite3.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/sqlite3.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.13/uuid.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/uuid.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.13/zlib.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/zlib.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.14/bzip2.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/bzip2.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.14/expat.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/expat.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.14/libcurl.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libcurl.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.14/libedit.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libedit.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.14/libexslt.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libexslt.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.14/libffi.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libffi.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.14/libxml-2.0.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libxml-2.0.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.14/libxslt.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libxslt.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.14/ncurses.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/ncurses.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.14/ncursesw.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/ncursesw.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.14/sqlite3.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/sqlite3.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.14/uuid.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/uuid.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.14/zlib.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/zlib.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.15/bzip2.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/bzip2.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.15/expat.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/expat.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.15/libcurl.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libcurl.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.15/libedit.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libedit.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.15/libexslt.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libexslt.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.15/libffi.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libffi.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.15/libxml-2.0.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libxml-2.0.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.15/libxslt.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libxslt.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.15/ncurses.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/ncurses.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.15/ncursesw.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/ncursesw.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.15/sqlite3.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/sqlite3.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.15/uuid.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/uuid.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.15/zlib.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/zlib.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.9/expat.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/expat.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.9/libcurl.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libcurl.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.9/libedit.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libedit.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.9/libexslt.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libexslt.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.9/libffi.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libffi.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.9/libxml-2.0.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libxml-2.0.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.9/libxslt.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libxslt.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.9/ncurses.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/ncurses.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.9/ncursesw.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/ncursesw.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.9/sqlite3.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/sqlite3.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.9/uuid.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/uuid.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/10.9/zlib.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/zlib.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/11/bzip2.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/bzip2.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/11/expat.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/expat.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/11/libcurl.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libcurl.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/11/libedit.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libedit.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/11/libexslt.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libexslt.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/11/libffi.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libffi.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/11/libxml-2.0.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libxml-2.0.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/11/libxslt.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libxslt.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/11/ncurses.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/ncurses.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/11/ncursesw.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/ncursesw.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/11/sqlite3.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/sqlite3.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/11/uuid.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/uuid.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/11/zlib.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/zlib.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/12/bzip2.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/bzip2.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/12/expat.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/expat.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/12/libcurl.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libcurl.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/12/libedit.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libedit.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/12/libexslt.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libexslt.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/12/libffi.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libffi.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/12/libxml-2.0.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libxml-2.0.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/12/libxslt.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libxslt.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/12/ncurses.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/ncurses.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/12/ncursesw.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/ncursesw.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/12/sqlite3.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/sqlite3.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/12/uuid.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/uuid.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/12/zlib.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/zlib.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/13/bzip2.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/bzip2.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/13/expat.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/expat.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/13/libcurl.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libcurl.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/13/libedit.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libedit.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/13/libexslt.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libexslt.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/13/libffi.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libffi.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/13/libxml-2.0.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libxml-2.0.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/13/libxslt.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libxslt.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/13/ncurses.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/ncurses.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/13/ncursesw.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/ncursesw.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/13/sqlite3.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/sqlite3.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/13/uuid.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/uuid.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/13/zlib.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/zlib.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/14/bzip2.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/bzip2.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/14/expat.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/expat.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/14/libcurl.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libcurl.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/14/libedit.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libedit.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/14/libexslt.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libexslt.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/14/libffi.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libffi.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/14/libxml-2.0.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libxml-2.0.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/14/libxslt.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libxslt.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/14/ncurses.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/ncurses.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/14/ncursesw.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/ncursesw.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/14/sqlite3.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/sqlite3.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/14/uuid.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/uuid.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/14/zlib.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/zlib.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/15/bzip2.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/bzip2.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/15/expat.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/expat.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/15/libcurl.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libcurl.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/15/libedit.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libedit.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/15/libexslt.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libexslt.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/15/libffi.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libffi.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/15/libxml-2.0.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libxml-2.0.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/15/libxslt.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/libxslt.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/15/ncurses.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/ncurses.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/15/ncursesw.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/ncursesw.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/15/sqlite3.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/sqlite3.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/15/uuid.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/uuid.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/15/zlib.pc: broken symbolic link to /home/build/melange-out/brew/usr/lib/pkgconfig/zlib.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/fuse/fuse.pc: broken symbolic link to /usr/local/lib/pkgconfig/fuse.pc
/home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig/fuse/osxfuse.pc: broken symbolic link to /usr/local/lib/pkgconfig/osxfuse.pc
6904c42c06d5:~#

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh, okay. Let me see this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, each of these sub-directories that exist in /home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig is being squashed when it goes to /usr/lib/pkconfig, so if pkgconfig/14/ncurses.pc and pkgconfig/15/ncurses.pc diverged, 14 will just end up overwritten with the version of ncurses.pc that was in pkgconfig/15. Can you avoid doing this? I'm not super familiar with pkgconf but if it searches sub-directories that would be preferable, and would allow for a brew subdirectory to also avoid a conflict with usr/lib/pkgconfig/ncurses.pc provided by ncurses-dev

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the creation of symlinks and rather modified the internal paths in .pc files.
Please take a look.

@priyanshuraj400 priyanshuraj400 force-pushed the brew-pkgconf branch 5 times, most recently from 5998cdf to 8529300 Compare March 10, 2025 17:26
@a-crate a-crate added the approved-to-run A repo member has approved this external contribution label Mar 10, 2025
@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Mar 10, 2025
@a-crate
Copy link
Member

a-crate commented Mar 11, 2025

I talked more with @murraybd about this and I think we're in agreement that this is probably not appropriate for brew to do actually, these pkgconf files seem intended for use by brew-managed packages, not apk-managed packages, and it (brew) shouldn't start installing them to a location that implies other apk packages should use them.

One solution is for the pkgconf test pipeline to allow a list of directories ignored during testing, and for brew to pass home/linuxbrew/.linuxbrew/Library/Homebrew/os/mac/pkgconfig into that.

@priyanshuraj400
Copy link
Author

Oh, I see. So in that case, we need to implement this skip check in pkgconf.yaml file in pipelines/test directory, right?

@a-crate
Copy link
Member

a-crate commented Mar 11, 2025

Yes, that's right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuananh tuananh tuananh left review comments

@a-crate a-crate a-crate requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
approved-to-run A repo member has approved this external contribution bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@priyanshuraj400 @a-crate @tuananh