-
Notifications
You must be signed in to change notification settings - Fork 344
update package pipeline and add bitnami-compat #43665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: YashPimple <[email protected]>
Signed-off-by: YashPimple <[email protected]>
Signed-off-by: YashPimple <[email protected]>
Signed-off-by: YashPimple <[email protected]>
Please use 👍 or 👎 on this comment to indicate if you agree or disagree with the recommendation. To provide more detailed feedback please comment on the recommendation prefixed with /ai-verify: e.g. /ai-verify partially helpful but I also added bash to the build environment Gen AI suggestions to solve the build error: Based on the error output, I'll analyze and provide specific fixes: • Detected Error: "install: omitting directory 'clean'" • Error Category: Configuration/Pipeline • Failure Point: In the pipeline step trying to install directories with: for i in clean custom raw; do
install -Dm644 "$i" "${{targets.destdir}}"/opt/jsonnet/grafonnet/
done • Root Cause Analysis: The • Suggested Fix: Replace the directory installation loop with either - runs: |
mkdir -p ${{targets.destdir}}/opt/jsonnet/grafonnet
cd gen/grafonnet-$GRAFONNET_VERSION
install -m755 *.libsonnet "${{targets.destdir}}"/opt/jsonnet/grafonnet/
install -m755 *.json "${{targets.destdir}}"/opt/jsonnet/grafonnet/
# Replace the problematic loop with:
for dir in clean custom raw; do
mkdir -p "${{targets.destdir}}/opt/jsonnet/grafonnet/$dir"
cp -r "$dir"/* "${{targets.destdir}}/opt/jsonnet/grafonnet/$dir/"
done • Explanation: The original command tried to use • Additional Notes:
• References:
|
Signed-off-by: YashPimple <[email protected]>
Signed-off-by: YashPimple <[email protected]>
This PR resolves the issue with nested directories within
/opt/jsonnet/grafonnet/
and improve alignment with the source structure.Earlier the pipeline use to create an nested directories like
/opt/jsonnet/grafonnet/clean/clean/
,/opt/jsonnet/grafonnet/custom/custom/,
and/opt/jsonnet/grafonnet/raw/raw/
due tomv
placing each source directory inside a pre-created subdirectory.The PR replaces
mv
with a conditionalcp -r
which copy each directory (clean/, custom/, raw/) directly into/opt/jsonnet/grafonnet/
preserving their structure without nesting.Also add bitnami compat package for grafonnet as per the Dockerfile
Pre-review Checklist
For new package PRs only
endoflife.date
)For new version streams
name: ${{package.name}}-compat
)provides:
logical unversioned forms of the package (e.g.nodejs
,nodejs-lts
)For package updates (renames) in the base images
When updating packages part of base images (i.e. cgr.dev/chainguard/wolfi-base or ghcr.io/wolfi-dev/sdk)
apk upgrade --latest
successfully upgrades packages or performs no actionsFor security-related PRs
For version bump PRs
epoch
field is reset to 0For PRs that add patches