Skip to content

Fixed checkov pkgconf pipeline test failure #44540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

priyanshuraj400
Copy link

Fixes:
#34007

Related:
#32554

Copy link
Member

@sergiodj sergiodj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @priyanshuraj400!

This PR suffers from the same problems as #44714 , and I believe we'll need a similar solution as well. Could you please give it a go and try to modify it accordingly?

Thanks!

@priyanshuraj400 priyanshuraj400 force-pushed the checkov-pkgconf branch 2 times, most recently from 31dee3a to b8832dc Compare March 10, 2025 17:26
@priyanshuraj400
Copy link
Author

Hello @sergiodj,
Implemented the changes. Please proceed.

@priyanshuraj400
Copy link
Author

Hi @sergiodj, @murraybd,
I have implemented the fixes, can we close this?

@murraybd
Copy link
Member

The test passed for me when I ran it locally:

2025/04/22 21:43:53 INFO running step "test/pkgconf"
2025/04/22 21:43:53 WARN + '[' -d /home/build ]
2025/04/22 21:43:53 WARN + cd /home/build
2025/04/22 21:43:53 WARN + exit 0
2025/04/22 21:43:53 INFO running step "pkgconf build dependency check"
2025/04/22 21:43:53 WARN + '[' -d /home/build ]
2025/04/22 21:43:53 WARN + cd /home/build
2025/04/22 21:43:53 WARN + basename /home/build/melange-out/checkov
2025/04/22 21:43:53 WARN + dev_pkg=checkov
2025/04/22 21:43:53 WARN + cd /
2025/04/22 21:43:53 WARN + pc_files=false
2025/04/22 21:43:53 WARN + apk info -L checkov
2025/04/22 21:43:53 WARN + grep '\.pc$'
2025/04/22 21:43:53 WARN + pc_files=true
2025/04/22 21:43:53 WARN + grep -q ^Name: usr/lib/pkgconfig/numpy.pc
2025/04/22 21:43:53 WARN + basename usr/lib/pkgconfig/numpy.pc .pc
2025/04/22 21:43:53 WARN + lib_name=numpy
2025/04/22 21:43:53 WARN + echo usr/lib/pkgconfig/numpy.pc
2025/04/22 21:43:53 WARN + grep -q '^usr/lib/pkgconfig/numpy.pc$\|^usr/share/pkgconfig/numpy.pc$'
2025/04/22 21:43:53 WARN + pkgconf --exists numpy
2025/04/22 21:43:53 WARN + grep -q ^Version: usr/lib/pkgconfig/numpy.pc
2025/04/22 21:43:53 WARN + pkgconf --modversion numpy
2025/04/22 21:43:53 INFO 2.2.5
2025/04/22 21:43:53 WARN + grep -q ^Libs: usr/lib/pkgconfig/numpy.pc
2025/04/22 21:43:53 WARN + grep -q ^Cflags: usr/lib/pkgconfig/numpy.pc
2025/04/22 21:43:53 WARN + pkgconf --cflags numpy
2025/04/22 21:43:53 INFO -I/usr/share/app/checkov/.venv/lib/python3.11/site-packages/numpy/_core/lib/pkgconfig/../../include
2025/04/22 21:43:53 WARN + '[' true '=' false ]
2025/04/22 21:43:53 WARN + exit 0

@murraybd murraybd added the approved-to-run A repo member has approved this external contribution label Apr 22, 2025
@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Apr 22, 2025
@debasishbsws
Copy link
Member

Thank you for your contribution. this has been fixed in #54300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-to-run A repo member has approved this external contribution bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants