Fixed ninja-build pkgconf pipeline test failure #44713
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiodj
previously requested changes
Mar 6, 2025
There was a problem hiding this comment.
Thanks, @priyanshuraj400!
This PR suffers from the same problems as #44714 , and I believe we'll need a similar solution as well. Could you please give it a go and try to modify it accordingly?
Thanks!
priyanshuraj400
force-pushed
the
ninja-build-pkgconf
branch
2 times, most recently
from
fa4b8b7 to
f1d6df1
Compare
|
Hello @sergiodj, |
priyanshuraj400
force-pushed
the
ninja-build-pkgconf
branch
from
f1d6df1 to
94dd199
Compare
priyanshuraj400
force-pushed
the
ninja-build-pkgconf
branch
from
94dd199 to
c6e53f4
Compare
priyanshuraj400
force-pushed
the
ninja-build-pkgconf
branch
from
c6e53f4 to
02a18fe
Compare
murraybd
dismissed
sergiodj’s stale review
The changes are in line with Sergio's request.
|
This passed for me locally but the PR is missing an epoch bump and has an extra line at the end of the yaml file. |
murraybd
added
the
approved-to-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
#34362
Related:
#32554