Skip to content

add pipeline to use CMake for building and installing libqrencode #52295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

senare
Copy link

@senare senare commented May 2, 2025

Fixes:
#33188

Related:
based of #34086

Pre-review Checklist

For new package PRs only

  • [X ] This PR is marked as fixing a pre-existing package request bug
  • REQUIRED - The package is available under an OSI-approved or FSF-approved license
  • REQUIRED - The version of the package is still receiving security updates
  • This PR links to the upstream project's support policy (e.g. endoflife.date)

For new version streams

  • The upstream project actually supports multiple concurrent versions.
  • Any subpackages include the version string in their package name (e.g. name: ${{package.name}}-compat)
  • The package (and subpackages) provides: logical unversioned forms of the package (e.g. nodejs, nodejs-lts)
  • If non-streamed package names no longer built, open PR to withdraw them (see WITHDRAWING PACKAGES)

For package updates (renames) in the base images

When updating packages part of base images (i.e. cgr.dev/chainguard/wolfi-base or ghcr.io/wolfi-dev/sdk)

  • REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk images successfully build
  • REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk contain no obsolete (no longer built) packages
  • Upon launch, does apk upgrade --latest successfully upgrades packages or performs no actions

For security-related PRs

  • The security fix is recorded in the advisories repo

For version bump PRs

  • The epoch field is reset to 0

For PRs that add patches

  • Patch source is documented

@senare senare force-pushed the cmake_build_libqrencode_pkg branch from c5021a9 to 06142dd Compare May 2, 2025 14:46
@senare
Copy link
Author

senare commented May 4, 2025

@kranurag7

Could you review ?

Approve to run CI/CD ?

@senare
Copy link
Author

senare commented May 5, 2025

Oki I am not really sure how to get some one to review, approve for CI etc here ?

please point me in the right direction ?

Should I just tag some one asking for review ?
@imjasonh @kranurag7

@imjasonh imjasonh added the approved-to-run A repo member has approved this external contribution label May 5, 2025
@kranurag7
Copy link
Member

@senare sorry for the delay, I'll review it shortly.

@senare senare force-pushed the cmake_build_libqrencode_pkg branch from 442112e to 206f6b6 Compare May 5, 2025 14:55
Copy link
Contributor

octo-sts bot commented May 5, 2025

❓ Build Failed: Unknown

Log incomplete - ends after dependency installation without showing build process or errors

Build Details

Category Details
Build System melange
Failure Point Unable to determine - log ends after dependency installation

Root Cause Analysis 🔍

The provided log is incomplete and only shows the preparatory phase where dependencies are being installed. It doesn't contain any actual build commands or errors for the libqrencode package.


Was this comment helpful? Please use 👍 or 👎 reactions on this comment.

@octo-sts octo-sts bot added the ai/skip-comment Stop AI from commenting on PR label May 5, 2025
@senare
Copy link
Author

senare commented May 7, 2025

Oki, so I think I might need some help with why this is stuck ?

I manage to build (and use this locally) but would like for it to be a proper-pkg !

So I can't seam to view the logs (I am missing access) telling why this is failing .. so some sort of insight into whats going on would be great !

I suspect there to be som issue around the git tag ? unclear to me what the intended solution would be ... there isa v in the tag sometimes ? always ? so where should I add the v ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ai/skip-comment Stop AI from commenting on PR approved-to-run A repo member has approved this external contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants