Rabbitmq default user credential bitnami compat #53291
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octo-sts
bot
added
the
bincapz/pass
rahulduvedi
force-pushed
the
rabbitmq-default-user-credential-bitnami-compat
branch
from
f65d65d to
21aa68c
Compare
rahulduvedi
force-pushed
the
rabbitmq-default-user-credential-bitnami-compat
branch
from
21aa68c to
8215e27
Compare
Dentrax
requested changes
May 14, 2025
| mkdir -p "${{targets.subpkgdir}}"/opt/bitnami/rmq-default-credential-updater/licenses | ||
| cp LICENSE "${{targets.subpkgdir}}"/opt/bitnami/rmq-default-credential-updater/licenses/LICENSE | ||
|
|
||
| rm -rf "${{targets.subpkgdir}}"/etc/ssl/certs/ca-certificates.crt |
There was a problem hiding this comment.
Can we put a comment above to explain why we are doing this?
Comment on lines
+67
to
+68
| [ -d "/opt/bitnami/rmq-default-credential-updater/licenses" ] | ||
| [ -f "/opt/bitnami/rmq-default-credential-updater/licenses/LICENSE" ] |
There was a problem hiding this comment.
Can we use readlink to test the symlinks?
vaikas
added
the
staging-build
mamccorm
requested changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added new bitami compatable subpackage to rabbitmq-default-user-credential-updater