glibc: Enable openssf-compiler-options #53351
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergio Durigan Junior <[email protected]>
octo-sts
bot
added
the
bincapz/pass
sergiodj
changed the title
|
We merged this before, but it resulted in an incident where a number of binaries were segfaulting. |
dannf
requested changes
May 14, 2025
Some of the hardening enablement requires rebuilding / rebootstrapping in order. We did it a few times before in debian and ubuntu. If we look through mailing list archives there should be messages from @doko42 about it. Possibly @stevebeattie remembers it too? |
|
@eslerm ^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore openssf-compiler-options hardening on glibc.
This build is now passing on both amd64 and arm64.
Relates: https://github.com/chainguard-dev/internal-dev/issues/7756
Relates: #39303
Relates: https://github.com/chainguard-dev/internal-dev/issues/7940