Skip to content

fix(kubevela): split vela-cli into its own subpackage #53358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 15, 2025

Conversation

tulilirockz
Copy link
Member

@tulilirockz tulilirockz commented May 14, 2025

That way we dont need to have the entire vela-cli when installing the kubevela operator (vela-core).
Saves about 40MB when you just want the operator

image

I'm not how to approach this tho, should it be an entirely separate package or just a subpackage here?

@tulilirockz tulilirockz marked this pull request as draft May 14, 2025 19:10
Signed-off-by: Arthur Exaltação <[email protected]>
Signed-off-by: Arthur Exaltação <[email protected]>
@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label May 14, 2025
@tulilirockz tulilirockz marked this pull request as ready for review May 14, 2025 19:24
Copy link
Member

@jamonation jamonation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's figure out how to refactor the subpackage/package dependencies to ensure apk add kubevela gets the CLI version

@tulilirockz tulilirockz requested a review from jamonation May 15, 2025 12:06
@tulilirockz
Copy link
Member Author

Split the package into vela-core + vela-cli now and a depends for the kubevela, that way we have the same functionality for kubevela and we can install them separately if we want to. (As @jamonation suggested)

Signed-off-by: Arthur Exaltação <[email protected]>
Co-authored-by: Jamon Camisso <[email protected]>
Signed-off-by: Tulip Blossom <[email protected]>
@jamonation jamonation merged commit cb3e626 into wolfi-dev:main May 15, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants