Skip to content

Added extra info to CLAUDE.md, which was used to create a test for amazon-corretto-crypto-provider #53364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025
Merged

Added extra info to CLAUDE.md, which was used to create a test for amazon-corretto-crypto-provider #53364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8f8914
Added extra info to CLAUDE.md, which was used to create a test for am…
AmberArcadia May 14, 2025
233b902
Cleanup fixes
AmberArcadia May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ tramp
.\#*

**/.github-token
**/.claude/settings.local.json

# QEMU images
*.img
8 changes: 8 additions & 0 deletions CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,14 @@ Try to reuse existing melange pipelines where possible.

When debugging failed builds, try cloning the source code from the melange file locally to a directory here to study the build system.

## Other General notes
Follow the previously mentioned notes as a baseline, and then also consider these additional notes:
- Certain packages are a bit weird, like Java and Python. Make sure to check existing examples, but especially note the following:
- Use py3.x-supported-y packages whenever possible
- Use a modern and supported JVM/JDK version (making sure to pick the right packages as well) and loading the environment variables properly
- Avoid using obsolete package versions
- It is worthwhile to search for similar packages to use as working examples over generating something entirely new.

## Ruby Package Guidelines

When working with Ruby packages:
Expand Down
12 changes: 12 additions & 0 deletions amazon-corretto-crypto-provider.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ package:
The Amazon Corretto Crypto Provider (ACCP) is a collection of high-performance cryptographic implementations exposed via the standard JCA/JCE interfaces.
copyright:
- license: Apache-2.0
dependencies:
runtime:
- openjdk-11-jre

environment:
contents:
Expand Down Expand Up @@ -38,6 +41,15 @@ pipeline:
mkdir -p ${{targets.destdir}}/usr/share/java/amazon-corretto-crypto-provider
mv build/lib/AmazonCorrettoCryptoProvider.jar ${{targets.destdir}}/usr/share/java/amazon-corretto-crypto-provider/AmazonCorrettoCryptoProvider.jar

test:
environment:
environment:
JAVA_HOME: /usr/lib/jvm/java-11-openjdk
pipeline:
- name: Verify JAR is not malformed
runs: |
unzip -l /usr/share/java/amazon-corretto-crypto-provider/AmazonCorrettoCryptoProvider.jar | grep AmazonCorrettoCryptoProvider.class

update:
enabled: true
github:
Expand Down
Loading