Unify module caches #1120
Open
Unify module caches #1120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lectem
force-pushed
the
refactor/unify-module-caches
branch
from
663ec72 to
c54b9b8
Compare
|
Rebased due to merge conflicts. |
|
Is there anything holding this PR back? |
wolfpld
reviewed
Sep 16, 2025
wolfpld
reviewed
Sep 16, 2025
wolfpld
reviewed
Sep 16, 2025
wolfpld
reviewed
Sep 16, 2025
I don't have appropriate tools to review the diff (it's practically everything in one commit). Currently looking for some way to print the diff on the paper so I can write some notes. |
wolfpld
reviewed
Oct 11, 2025
wolfpld
reviewed
Oct 11, 2025
wolfpld
reviewed
Oct 11, 2025
wolfpld
reviewed
Oct 11, 2025
wolfpld
reviewed
Oct 11, 2025
wolfpld
reviewed
Oct 11, 2025
wolfpld
reviewed
Oct 11, 2025
wolfpld
reviewed
Oct 11, 2025
wolfpld
reviewed
Oct 11, 2025
wolfpld
reviewed
Oct 11, 2025
wolfpld
reviewed
Oct 11, 2025
…iles in the future
… be used in server, and thus not pointing to current process memory
The name was a bit misleading as it could be mistaken to mean "The cache contains the address" and not as "has an image with this start address". ie: that it could be mistaken to do GetImageForAddress( startAddress ) != nullptr.
…dd DestroyImageEntry for ImageEntry cleanup
… on other platforms
Image cache will remain potentially unsorted until first access or `Sort` is called explicitely.
…IMAGE_CACHE Windows is already using a cache, and the only platforms that won't have one for now are those without dl_iterate_phdr.
- Introduce both s_imageCache and s_krnlCache on all platforms, even if unused (will be reused later to unify platforms handling) - This means that what userland images that used to be unsorted are now sorted
Lectem
force-pushed
the
refactor/unify-module-caches
branch
from
9be221a to
aa234d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the changes we had in #1009
This is an attempt at unifying the symbol caching mechanisms between windows and linux.
It will later be the base for also storing module debug information (pdb guid, gnu_debug_id, ...).