Correctly handle object name in bytearray data #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The STL data may come as text or bytearray depending on the source. The STL output is using string formatting to output numbers, and later converts the formatted numbers to bytearray to write out. This does not work for the object name when it comes as byte array. Wehn formatted as string the extra b'' is added around it. Change the p() functio so that it can accept a byte array, and pass in the name as byte array. Convert the name to byte array before passing it to p() in the case it's text. This avoids the superfluous conversion. Fixes: wolph#233
|
Thanks for the fix! I suppose the code could be simplified anyhow, it's largely a remainder of the Python 2 compatibility but this fixes it nicely! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The STL data may come as text or bytearray depending on the source.
The STL output is using string formatting to output numbers, and later converts the formatted numbers to bytearray to write out.
This does not work for the object name when it comes as byte array. Wehn formatted as string the extra b'' is added around it.
Change the p() functio so that it can accept a byte array, and pass in the name as byte array. Convert the name to byte array before passing it to p() in the case it's text.
This avoids the superfluous conversion.
Fixes: #233