windows: import rn-fetch-blob on Windows#538
Merged
wonday merged 4 commits intoFeb 16, 2021
Merged
Conversation
Import rn-fetch-blob on all supported OSes.
jaimecbernardo
force-pushed
the
consume-rn-fetch-blob-windows
branch
from
February 10, 2021 15:36
1fe403b to
15f8719
Compare
jaimecbernardo
changed the title
jaimecbernardo
marked this pull request as ready for review
February 10, 2021 15:59
Contributor
Author
|
Hi @wonday , |
Owner
|
@jaimecbernardo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imports
rn-fetch-blobon Windows as well, with a fallback for functionality that doesn't needrn-fetch-blob.Adds an
ifguard on a possible source of flakiness for the Windows implementation.Fixes a build error when using with
react-native-windows 0.62.Updates the
README.mdfor Windows users to consume thern-fetch-blobPR that supports Windows.