Skip to content

Fix: return eTag with 304 responses #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Darilana
Copy link

This pull request adds an ETag to the response headers for 304 Not Modified responses, as specified by RFC 9110, Section 15.4.5

The server generating a 304 response MUST generate any of the following header fields that would have been sent in a 200 (OK) response to the same request:

Including the ETag in these responses helps clients validate cached content correctly and reduces unnecessary data transfers.
This change brings the implementation more in line with HTTP standards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant