Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2460 google ads value prop #2635

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

joemcgill
Copy link
Collaborator

Changes proposed in this Pull Request:

Closes #2460.

This is a feature branch containing the following PRs:

Screenshots:

Detailed test instructions:

Additional details:

Changelog entry

@joemcgill joemcgill self-assigned this Sep 30, 2024
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.7%. Comparing base (1c6a902) to head (ac6e716).
Report is 15 commits behind head on develop.

Files with missing lines Patch % Lines
js/src/dashboard/summary-section/index.js 50.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #2635      +/-   ##
============================================
- Coverage       65.3%   62.7%    -2.6%     
============================================
  Files            474     319     -155     
  Lines          17893    5074   -12819     
  Branches           0    1231    +1231     
============================================
- Hits           11685    3180    -8505     
+ Misses          6208    1721    -4487     
- Partials           0     173     +173     
Flag Coverage Δ
js-unit-tests 62.7% <50.0%> (?)
php-unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
js/src/dashboard/summary-section/index.js 81.2% <50.0%> (ø)

... and 792 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post Onboarding Overview
2 participants