Fix customer name display when filtering from order details

When clicking "View customer orders" from order details, the filter view now shows the customer name instead of ID. Implemented by passing the customer object through a temporary repository field that triggers the existing onCustomerSelected() logic when the filter screen opens.

Author: kidinov

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/orders/filters/OrderFilterCategoriesFragment.kt

@@ -101,6 +101,8 @@ class OrderFilterCategoriesFragment :
         handleResult<Order.Customer>(KEY_CUSTOMER_RESULT) {
             viewModel.onCustomerSelected(it)
         }
+
+        viewModel.checkPendingCustomerResult()
     }
 
     fun onPrepareMenu(menu: Menu) {

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/orders/filters/OrderFilterCategoriesViewModel.kt

@@ -91,12 +91,6 @@ class OrderFilterCategoriesViewModel @Inject constructor(
                 savedState[OLD_FILTER_SELECTION_KEY] = oldFilterSelection
             }
         }
-
-        launch {
-            orderFilterRepository.customerSelectedEvent.collect { customer ->
-                onCustomerSelected(customer)
-            }
-        }
     }
 
     fun onFilterCategorySelected(filterCategory: OrderFilterCategoryUiModel) {
@@ -353,6 +347,13 @@ class OrderFilterCategoriesViewModel @Inject constructor(
         }
     }
 
+    fun checkPendingCustomerResult() {
+        orderFilterRepository.pendingCustomerResult?.let { customer ->
+            orderFilterRepository.pendingCustomerResult = null
+            onCustomerSelected(customer)
+        }
+    }
+
     fun onProductSelected(productId: Long) {
         orderFilterRepository.productFilter = productId
         onFilterOptionsUpdated(

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/orders/filters/data/OrderFiltersRepository.kt

@@ -7,9 +7,6 @@ import com.woocommerce.android.tools.SelectedSite
 import com.woocommerce.android.ui.orders.filters.data.OrderListFilterCategory.CUSTOMER
 import com.woocommerce.android.ui.orders.filters.data.OrderListFilterCategory.PRODUCT
 import kotlinx.coroutines.CoroutineScope
-import kotlinx.coroutines.flow.MutableSharedFlow
-import kotlinx.coroutines.flow.SharedFlow
-import kotlinx.coroutines.flow.asSharedFlow
 import kotlinx.coroutines.flow.distinctUntilChanged
 import kotlinx.coroutines.flow.launchIn
 import kotlinx.coroutines.flow.onEach
@@ -26,12 +23,7 @@ class OrderFiltersRepository @Inject constructor(
 
     var customerFilter: Long? = null
 
-    private val _customerSelectedEvent = MutableSharedFlow<Order.Customer>(replay = 0)
-    val customerSelectedEvent: SharedFlow<Order.Customer> = _customerSelectedEvent.asSharedFlow()
-
-    suspend fun selectCustomer(customer: Order.Customer) {
-        _customerSelectedEvent.emit(customer)
-    }
+    var pendingCustomerResult: Order.Customer? = null
 
     init {
         selectedSite.observe()

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/orders/list/OrderListFragment.kt

@@ -20,7 +20,6 @@ import androidx.core.view.doOnPreDraw
 import androidx.core.view.isVisible
 import androidx.fragment.app.activityViewModels
 import androidx.fragment.app.viewModels
-import androidx.lifecycle.lifecycleScope
 import androidx.navigation.findNavController
 import androidx.navigation.fragment.NavHostFragment
 import androidx.navigation.fragment.findNavController
@@ -78,7 +77,6 @@ import com.woocommerce.android.util.StringUtils
 import com.woocommerce.android.viewmodel.MultiLiveEvent
 import com.woocommerce.android.widgets.WCEmptyView.EmptyViewType
 import dagger.hilt.android.AndroidEntryPoint
-import kotlinx.coroutines.launch
 import org.wordpress.android.util.ToastUtils
 import javax.inject.Inject
 import org.wordpress.android.util.ActivityUtils as WPActivityUtils
@@ -927,9 +925,8 @@ class OrderListFragment :
 
     fun applyCustomerFilter(customer: Order.Customer) {
         searchQuery = ""
-        viewLifecycleOwner.lifecycleScope.launch {
-            orderFiltersRepository.selectCustomer(customer)
-        }
+        orderFiltersRepository.customerFilter = customer.customerId
+        orderFiltersRepository.pendingCustomerResult = customer
         viewModel.loadOrders()
 
         uiMessageResolver.showSnack(R.string.order_list_customer_filter_applied)