-
Notifications
You must be signed in to change notification settings - Fork 136
[Mobile Payments] Fix pay in person learn more link #12786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile Payments] Fix pay in person learn more link #12786
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #12786 +/- ##
============================================
- Coverage 40.84% 40.84% -0.01%
+ Complexity 5744 5742 -2
============================================
Files 1236 1236
Lines 69687 69685 -2
Branches 9663 9662 -1
============================================
- Hits 28466 28465 -1
Misses 38596 38596
+ Partials 2625 2624 -1 ☔ View full report in Codecov by Sentry. |
samiuelson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ![]()
Closes: #12729
Description
This PR fixes the incorrect "Learn More" link for the Pay in Person option in the payments menu. Previously, we used two different links for WooCommerce Payments and the Stripe payment gateway, but the content at these URLs had moved, resulting in irrelevant content being displayed. Now, a single URL is used, providing the correct information for both payment gateways.
Steps to reproduce
learn morelink under thePay in Personoptioncash on deliveryis opened.The tests that have been performed
Tested that the URL content is proper for Pay in Person option.
Images/gif
cod_learn_more.mp4
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: