Skip to content

Conversation

@AnirudhBhat
Copy link
Contributor

Closes: #12729

Description

This PR fixes the incorrect "Learn More" link for the Pay in Person option in the payments menu. Previously, we used two different links for WooCommerce Payments and the Stripe payment gateway, but the content at these URLs had moved, resulting in irrelevant content being displayed. Now, a single URL is used, providing the correct information for both payment gateways.

Steps to reproduce

  1. Navigate to payments menu (More menu -> Payments)
  2. Click on learn more link under the Pay in Person option
  3. Ensure relevant page about cash on delivery is opened.

The tests that have been performed

Tested that the URL content is proper for Pay in Person option.

Images/gif

cod_learn_more.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@AnirudhBhat AnirudhBhat added type: bug A confirmed bug. feature: mobile payments Related to mobile payments / card present payments / Woo Payments. labels Oct 16, 2024
@AnirudhBhat AnirudhBhat added this to the 20.8 milestone Oct 16, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 20.8. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 16, 2024

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit34db50b
Direct Downloadwoocommerce-wear-prototype-build-pr12786-34db50b.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 16, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit34db50b
Direct Downloadwoocommerce-prototype-build-pr12786-34db50b.apk

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.84%. Comparing base (dd1bf89) to head (7afe350).

Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #12786      +/-   ##
============================================
- Coverage     40.84%   40.84%   -0.01%     
+ Complexity     5744     5742       -2     
============================================
  Files          1236     1236              
  Lines         69687    69685       -2     
  Branches       9663     9662       -1     
============================================
- Hits          28466    28465       -1     
  Misses        38596    38596              
+ Partials       2625     2624       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@samiuelson samiuelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@samiuelson samiuelson enabled auto-merge October 17, 2024 20:02
@samiuelson samiuelson merged commit 84c967a into trunk Oct 17, 2024
3 checks passed
@samiuelson samiuelson deleted the issue/12729-fix-pay-in-person-learn-more-link branch October 17, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: mobile payments Related to mobile payments / card present payments / Woo Payments. type: bug A confirmed bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Mobile Payments] Incorrect Pay In Person learn more link

6 participants