Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 16, 2024

Bumps androidx-hilt from 1.1.0 to 1.2.0.
Updates androidx.hilt:hilt-common from 1.1.0 to 1.2.0

Updates androidx.hilt:hilt-compiler from 1.1.0 to 1.2.0

Updates androidx.hilt:hilt-navigation-compose from 1.1.0 to 1.2.0

Updates androidx.hilt:hilt-navigation-fragment from 1.1.0 to 1.2.0

Updates androidx.hilt:hilt-work from 1.1.0 to 1.2.0

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps `androidx-hilt` from 1.1.0 to 1.2.0.

Updates `androidx.hilt:hilt-common` from 1.1.0 to 1.2.0

Updates `androidx.hilt:hilt-compiler` from 1.1.0 to 1.2.0

Updates `androidx.hilt:hilt-navigation-compose` from 1.1.0 to 1.2.0

Updates `androidx.hilt:hilt-navigation-fragment` from 1.1.0 to 1.2.0

Updates `androidx.hilt:hilt-work` from 1.1.0 to 1.2.0

---
updated-dependencies:
- dependency-name: androidx.hilt:hilt-common
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: androidx.hilt:hilt-compiler
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: androidx.hilt:hilt-navigation-compose
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: androidx.hilt:hilt-navigation-fragment
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: androidx.hilt:hilt-work
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the bot: dependencies update PRs that update a dependency file, used by Dependabot. label Oct 16, 2024
@dependabot dependabot bot requested review from a team and atorresveiga and removed request for a team October 16, 2024 11:35
@hichamboushaba hichamboushaba requested review from hichamboushaba and removed request for atorresveiga October 16, 2024 11:36
@hichamboushaba hichamboushaba self-assigned this Oct 16, 2024
@hichamboushaba
Copy link
Member

@atorresveiga this PR is a result of a rebase command that I started on a previous one #12148, which I was already planning to review, so I'm going to review this one instead 🙂.

@dangermattic
Copy link
Collaborator

dangermattic commented Oct 16, 2024

1 Warning
⚠️ This PR is assigned to the milestone 20.8. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

Project dependencies changes

The following changes in project dependencies were detected (configuration vanillaReleaseRuntimeClasspath):

list
Upgraded Dependencies
androidx.hilt:hilt-common:1.2.0, (changed from 1.1.0)
androidx.hilt:hilt-navigation:1.2.0, (changed from 1.1.0)
androidx.hilt:hilt-navigation-compose:1.2.0, (changed from 1.1.0)
androidx.hilt:hilt-navigation-fragment:1.2.0, (changed from 1.1.0)
androidx.hilt:hilt-work:1.2.0, (changed from 1.1.0)
tree
-+--- androidx.hilt:hilt-navigation-fragment:1.1.0
-|    +--- androidx.hilt:hilt-navigation:1.1.0
-|    |    +--- androidx.annotation:annotation:1.1.0 -> 1.8.0 (*)
-|    |    +--- androidx.navigation:navigation-runtime:2.5.1 -> 2.7.7 (*)
-|    |    +--- com.google.dagger:hilt-android:2.48 -> 2.50 (*)
-|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.25 (*)
-|    +--- androidx.navigation:navigation-fragment-ktx:2.5.1 -> 2.7.7
-|    |    +--- androidx.navigation:navigation-fragment:2.7.7 (*)
-|    |    +--- androidx.navigation:navigation-runtime-ktx:2.7.7 (*)
-|    |    +--- androidx.navigation:navigation-common:2.7.7 (c)
-|    |    +--- androidx.navigation:navigation-compose:2.7.7 (c)
-|    |    +--- androidx.navigation:navigation-fragment:2.7.7 (c)
-|    |    +--- androidx.navigation:navigation-runtime:2.7.7 (c)
-|    |    +--- androidx.navigation:navigation-runtime-ktx:2.7.7 (c)
-|    |    +--- androidx.navigation:navigation-ui:2.7.7 (c)
-|    |    \--- androidx.navigation:navigation-common-ktx:2.7.7 (c)
-|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.25 (*)
++--- androidx.hilt:hilt-navigation-fragment:1.2.0
+|    +--- androidx.hilt:hilt-navigation:1.2.0
+|    |    +--- androidx.annotation:annotation:1.1.0 -> 1.8.0 (*)
+|    |    +--- androidx.navigation:navigation-runtime:2.5.1 -> 2.7.7 (*)
+|    |    +--- com.google.dagger:hilt-android:2.49 -> 2.50 (*)
+|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.25 (*)
+|    +--- androidx.navigation:navigation-fragment-ktx:2.5.1 -> 2.7.7
+|    |    +--- androidx.navigation:navigation-fragment:2.7.7 (*)
+|    |    +--- androidx.navigation:navigation-runtime-ktx:2.7.7 (*)
+|    |    +--- androidx.navigation:navigation-common:2.7.7 (c)
+|    |    +--- androidx.navigation:navigation-compose:2.7.7 (c)
+|    |    +--- androidx.navigation:navigation-fragment:2.7.7 (c)
+|    |    +--- androidx.navigation:navigation-runtime:2.7.7 (c)
+|    |    +--- androidx.navigation:navigation-runtime-ktx:2.7.7 (c)
+|    |    +--- androidx.navigation:navigation-ui:2.7.7 (c)
+|    |    \--- androidx.navigation:navigation-common-ktx:2.7.7 (c)
+|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.25 (*)
-+--- androidx.hilt:hilt-common:1.1.0
-|    \--- com.google.dagger:hilt-core:2.48 -> 2.50 (*)
++--- androidx.hilt:hilt-common:1.2.0
+|    \--- com.google.dagger:hilt-core:2.49 -> 2.50 (*)
-+--- androidx.hilt:hilt-work:1.1.0
-|    +--- androidx.annotation:annotation:1.1.0 -> 1.8.0 (*)
-|    +--- androidx.hilt:hilt-common:1.1.0 (*)
-|    +--- androidx.work:work-runtime:2.3.4 -> 2.7.1 (*)
-|    \--- com.google.dagger:hilt-android:2.48 -> 2.50 (*)
++--- androidx.hilt:hilt-work:1.2.0
+|    +--- androidx.annotation:annotation:1.1.0 -> 1.8.0 (*)
+|    +--- androidx.hilt:hilt-common:1.2.0 (*)
+|    +--- androidx.work:work-runtime:2.3.4 -> 2.7.1 (*)
+|    \--- com.google.dagger:hilt-android:2.49 -> 2.50 (*)
-\--- androidx.hilt:hilt-navigation-compose:1.1.0
-     +--- androidx.compose.runtime:runtime:1.0.1 -> 1.6.5 (*)
-     +--- androidx.compose.ui:ui:1.0.1 -> 1.6.5 (*)
-     +--- androidx.hilt:hilt-navigation:1.1.0 (*)
-     +--- androidx.lifecycle:lifecycle-viewmodel-compose:2.6.1 -> 2.7.0 (*)
-     +--- androidx.navigation:navigation-compose:2.5.1 -> 2.7.7 (*)
-     \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.25 (*)
+\--- androidx.hilt:hilt-navigation-compose:1.2.0
+     +--- androidx.compose.runtime:runtime:1.0.1 -> 1.6.5 (*)
+     +--- androidx.compose.ui:ui:1.0.1 -> 1.6.5 (*)
+     +--- androidx.hilt:hilt-navigation:1.2.0 (*)
+     +--- androidx.lifecycle:lifecycle-viewmodel-compose:2.6.1 -> 2.7.0 (*)
+     +--- androidx.navigation:navigation-compose:2.5.1 -> 2.7.7 (*)
+     \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.25 (*)

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 16, 2024

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit940cd21
Direct Downloadwoocommerce-wear-prototype-build-pr12791-940cd21.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 16, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit940cd21
Direct Downloadwoocommerce-prototype-build-pr12791-940cd21.apk

@hichamboushaba hichamboushaba added this to the 20.8 milestone Oct 16, 2024
Copy link
Member

@hichamboushaba hichamboushaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hichamboushaba hichamboushaba merged commit fa9bb72 into trunk Oct 16, 2024
4 checks passed
@hichamboushaba hichamboushaba deleted the dependabot/gradle/androidx-hilt-1.2.0 branch October 16, 2024 12:54
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 40.84%. Comparing base (daca67d) to head (940cd21).
Report is 4 commits behind head on trunk.

Files with missing lines Patch % Lines
...e/android/ui/dashboard/blaze/DashboardBlazeCard.kt 0.00% 1 Missing ⚠️
...droid/ui/dashboard/coupons/DashboardCouponsCard.kt 0.00% 1 Missing ⚠️
...roid/ui/dashboard/google/DashboardGoogleAdsCard.kt 0.00% 1 Missing ⚠️
...e/android/ui/dashboard/inbox/DashboardInboxCard.kt 0.00% 1 Missing ⚠️
...ui/dashboard/onboarding/DashboardOnboardingCard.kt 0.00% 1 Missing ⚠️
...android/ui/dashboard/orders/DashboardOrdersCard.kt 0.00% 1 Missing ⚠️
...droid/ui/dashboard/reviews/DashboardReviewsCard.kt 0.00% 1 Missing ⚠️
...e/android/ui/dashboard/stats/DashboardStatsCard.kt 0.00% 1 Missing ⚠️
...id/ui/dashboard/stock/DashboardProductStockCard.kt 0.00% 1 Missing ⚠️
.../topperformers/DashboardTopPerformersWidgetCard.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##              trunk   #12791   +/-   ##
=========================================
  Coverage     40.84%   40.84%           
- Complexity     5754     5755    +1     
=========================================
  Files          1237     1237           
  Lines         69742    69742           
  Branches       9680     9680           
=========================================
+ Hits          28483    28484    +1     
  Misses        38634    38634           
+ Partials       2625     2624    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sentry
Copy link

sentry bot commented Oct 16, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ApplicationNotResponding: ANR com.woocommerce.android.ui.blaze.creation.ad.Pr... View Issue
  • ‼️ ApplicationNotResponding: ANR Dashboard View Issue
  • ‼️ ApplicationNotResponding: Background ANR androidx.lifecycle.viewmodel.compose.ViewModelK... View Issue
  • ‼️ ApplicationNotResponding: Background ANR Dashboard View Issue
  • ‼️ ApplicationNotResponding: ANR OrderDetails View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot: dependencies update PRs that update a dependency file, used by Dependabot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants