-
Notifications
You must be signed in to change notification settings - Fork 136
[Product Global Unique Identifier] Model & show value #12984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Product Global Unique Identifier] Model & show value #12984
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
https://github.com/woocommerce/woocommerce-android into issue/12971-product-global-unique-id-networking-model # Conflicts: # gradle/libs.versions.toml
Project dependencies changesThe following changes in project dependencies were detected (configuration listtree-+--- org.wordpress:fluxc:2.100.0
-| +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.25 -> 2.0.21
-| | +--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 (*)
-| | \--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:2.0.21
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 (*)
-| +--- androidx.exifinterface:exifinterface:1.0.0 -> 1.3.6
-| | \--- androidx.annotation:annotation:1.2.0 -> 1.8.0 (*)
-| +--- androidx.security:security-crypto:1.0.0 -> 1.1.0-alpha03
-| | +--- androidx.annotation:annotation:1.1.0 -> 1.8.0 (*)
-| | +--- com.google.crypto.tink:tink-android:1.5.0
-| | \--- androidx.collection:collection:1.1.0 -> 1.4.0 (*)
-| +--- com.squareup.okhttp3:okhttp-urlconnection:4.9.0
-| | +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.12.0 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.10 -> 1.9.10 (*)
-| +--- com.google.code.gson:gson:2.8.5 -> 2.10.1
-| +--- org.apache.commons:commons-text:1.10.0 (*)
-| +--- androidx.room:room-runtime:2.6.1 (*)
-| +--- androidx.room:room-ktx:2.6.1
-| | +--- androidx.room:room-common:2.6.1 (*)
-| | +--- androidx.room:room-runtime:2.6.1 (*)
-| | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.21 (*)
-| | +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.7.1 -> 1.8.1 (*)
-| | +--- androidx.room:room-common:2.6.1 (c)
-| | \--- androidx.room:room-runtime:2.6.1 (c)
-| +--- com.google.dagger:dagger:2.51.1
-| | \--- javax.inject:javax.inject:1
-| +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.8.1 (*)
-| +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.8.1 (*)
-| +--- org.wordpress:wellsql:2.0.0
-| | +--- androidx.annotation:annotation:1.2.0 -> 1.8.0 (*)
-| | \--- org.wordpress.wellsql:wellsql-annotations:2.0.0
-| +--- org.wordpress.fluxc:fluxc-annotations:2.100.0
-| +--- org.greenrobot:eventbus:3.3.1 (*)
-| +--- org.greenrobot:eventbus-java:3.3.1
-| +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.12.0 (*)
-| +--- com.android.volley:volley:1.1.1 -> 1.2.0
-| +--- androidx.paging:paging-runtime:2.1.2
-| | +--- androidx.paging:paging-common:2.1.2
-| | | +--- androidx.annotation:annotation:1.0.0 -> 1.8.0 (*)
-| | | \--- androidx.arch.core:core-common:2.0.0 -> 2.2.0 (*)
-| | +--- androidx.arch.core:core-runtime:2.0.0 -> 2.2.0 (*)
-| | +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.7.0 (*)
-| | +--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.7.0 (*)
-| | \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.2 (*)
-| +--- com.goterl:lazysodium-android:5.0.2
-| +--- net.java.dev.jna:jna:5.5.0
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.25 -> 2.0.21 (*)
++--- org.wordpress:fluxc:trunk-3d095f6f0a41e50faab2038a9f195f536b6e4520 FAILED
-+--- org.wordpress.fluxc.plugins:woocommerce:2.100.0
-| +--- org.wordpress:fluxc:2.100.0 (*)
-| +--- com.google.code.gson:gson:2.8.5 -> 2.10.1
-| +--- com.google.dagger:dagger:2.51.1 (*)
-| +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.8.1 (*)
-| +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.8.1 (*)
-| +--- androidx.room:room-runtime:2.6.1 (*)
-| +--- org.wordpress:wellsql:2.0.0 (*)
-| +--- org.wordpress.fluxc:fluxc-annotations:2.100.0
-| +--- androidx.room:room-ktx:2.6.1 (*)
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.25 -> 2.0.21 (*)
++--- org.wordpress.fluxc.plugins:woocommerce:trunk-3d095f6f0a41e50faab2038a9f195f536b6e4520 FAILED
+--- org.wordpress:login:1.19.0
| +--- com.github.bumptech.glide:glide:4.12.0 -> 4.16.0
-| | \--- androidx.exifinterface:exifinterface:1.3.6 (*)
+| | \--- androidx.exifinterface:exifinterface:1.3.6
+| | \--- androidx.annotation:annotation:1.2.0 -> 1.8.0 (*)
-| \--- com.google.dagger:dagger:2.47 -> 2.51.1 (*)
+| \--- com.google.dagger:dagger:2.47 -> 2.51.1
+| \--- javax.inject:javax.inject:1
\--- project :libs:cardreader
+--- com.stripe:stripeterminal-localmobile:3.7.1
- | \--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.24 -> 2.0.21 (*)
+ | \--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.24 -> 2.0.21
+ | +--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 (*)
+ | \--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:2.0.21
+ | \--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 (*)
\--- com.stripe:stripeterminal-core:3.7.1
- +--- androidx.security:security-crypto:1.1.0-alpha03 (*)
+ +--- androidx.security:security-crypto:1.1.0-alpha03
+ | +--- androidx.annotation:annotation:1.1.0 -> 1.8.0 (*)
+ | +--- com.google.crypto.tink:tink-android:1.5.0
+ | \--- androidx.collection:collection:1.1.0 -> 1.4.0 (*)
- \--- androidx.room:room-ktx:2.6.1 (*)
+ \--- androidx.room:room-ktx:2.6.1
+ +--- androidx.room:room-common:2.6.1 (*)
+ +--- androidx.room:room-runtime:2.6.1 (*)
+ +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.21 (*)
+ +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.7.1 -> 1.8.1 (*)
+ +--- androidx.room:room-common:2.6.1 (c)
+ \--- androidx.room:room-runtime:2.6.1 (c) |
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #12984 +/- ##
============================================
- Coverage 39.72% 39.71% -0.01%
- Complexity 6002 6032 +30
============================================
Files 1274 1274
Lines 73430 73453 +23
Branches 10070 10073 +3
============================================
+ Hits 29167 29175 +8
- Misses 41691 41702 +11
- Partials 2572 2576 +4 ☔ View full report in Codecov by Sentry. |
Closes: #12971
Description
With this PR we show the real value of the product unique global identifier on the UI. To achieve that we:
Steps to reproduce
Set the GTIN value on a product. Once you have that:
Testing information
The tests that have been performed
I checked that the flow works fine for GTIN values that only contains numbers and also strings (hyphens)
Images/gif
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: