Skip to content

Conversation

@wzieba
Copy link
Contributor

@wzieba wzieba commented Nov 22, 2024

Closes: #

Description

This PR enables configuration cache to speed up execution of local tasks.

In addition it removes unused/updates Gradle tasks and addresses a minor deprecation.

Testing information

Run any task and see the terminal output for more information about storing and reusing configuation cache

The tests that have been performed

Above and I additionally browsed configuration in search for tasks that would be not configuration cache compatible. After recent clean ups, we only have a few of them and they seem to work fine.

Images/gif

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

It was added to raise awareness of `--auto-correct` feature and I think it already fulfilled its purpose.

I remove this task because it's not configuration-cache compatible and I don't think it's worth to spend time on making it compatible
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitb27a044
Direct Downloadwoocommerce-wear-prototype-build-pr12988-b27a044.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitb27a044
Direct Downloadwoocommerce-prototype-build-pr12988-b27a044.apk

@wzieba wzieba added type: enhancement A request for an enhancement. Core labels Nov 22, 2024
@wzieba wzieba added this to the 21.3 milestone Nov 22, 2024
@wzieba wzieba marked this pull request as ready for review November 22, 2024 12:30
@wzieba wzieba requested a review from ParaskP7 November 22, 2024 12:31
Copy link
Contributor

@ParaskP7 ParaskP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @wzieba !

I have reviewed and tested this PR as per the instructions, everything works as expected, good job! 🌟


image

image


I have just left a couple of questions (❓) for us to discuss. I am going to approve this PR anyway, since none is blocking. I am NOT going to merge this PR yet to give you some time to apply any of my suggestions. However, feel free to ignore them and merge the PR yourself.

@wzieba wzieba merged commit 6311891 into trunk Nov 25, 2024
19 checks passed
@wzieba wzieba deleted the enable_configuration_cache branch November 25, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Core type: enhancement A request for an enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants