-
Notifications
You must be signed in to change notification settings - Fork 136
Enable configuration cache #12988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable configuration cache #12988
Conversation
It was added to raise awareness of `--auto-correct` feature and I think it already fulfilled its purpose. I remove this task because it's not configuration-cache compatible and I don't think it's worth to spend time on making it compatible
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 @wzieba !
I have reviewed and tested this PR as per the instructions, everything works as expected, good job! 🌟
✅
✅
I have just left a couple of questions (❓) for us to discuss. I am going to approve this PR anyway, since none is blocking. I am NOT going to merge this PR yet to give you some time to apply any of my suggestions. However, feel free to ignore them and merge the PR yourself.


Closes: #
Description
This PR enables configuration cache to speed up execution of local tasks.
In addition it removes unused/updates Gradle tasks and addresses a minor deprecation.
Testing information
Run any task and see the terminal output for more information about storing and reusing configuation cache
The tests that have been performed
Above and I additionally browsed configuration in search for tasks that would be not configuration cache compatible. After recent clean ups, we only have a few of them and they seem to work fine.
Images/gif
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: