-
Notifications
You must be signed in to change notification settings - Fork 136
[Blaze] Add dialog when no product is found during Blaze intro in More Menu. #13001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #13001 +/- ##
=========================================
Coverage 39.72% 39.73%
- Complexity 6036 6037 +1
=========================================
Files 1274 1274
Lines 73453 73458 +5
Branches 10074 10074
=========================================
+ Hits 29177 29185 +8
+ Misses 41701 41699 -2
+ Partials 2575 2574 -1 ☔ View full report in Codecov by Sentry. |
JorgeMucientes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and works as expected. Nice job @hafizrahman. Just left a minor np, feel free to ignore it.
| navigateToProductSelectorScreen() | ||
| } | ||
|
|
||
| is BlazeCampaignCreationIntroViewModel.ShowNoProductCTA -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Np, and probably a matter of personal taste but I'd name this event ShowNoProductDialog to be explicit about showing a dialog. CTA sound to me like a button.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point, updated in ba897b7
At first I called it CTA because at the end of the day, there is only one successful path we want merchants to go to (create a product), otherwise the rest of Blaze flow can't be continued. But it did indeed sound weird because the event is showing a dialog, not just a single CTA.
|
I added an extra commit for cleaning up the dialog but it's not affecting anything in the test flow. |
Closes: #12503
Description
Currently, there is an issue where if the site has no product, the Blaze intro screen has no way to proceed with creating the campaign. This PR fixes that by adding a product creation step from the intro.
Steps to reproduce
Optional: trash the Product and start over from step 3 to 5, ensure it shows the dialog again.
Testing information
I tested this on an emulated Pixel 8 with API 32, following closely the steps above. I can't think of any edge cases yet, but let me know if there's other entry points aside from more menu that needs to be covered too.
The tests that have been performed
I tested following the steps outlined above.
Images/gif
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: