Skip to content

Conversation

@kidinov
Copy link
Contributor

@kidinov kidinov commented Nov 26, 2024

Closes: #12997

Description

Adds feature flags for the new features. No functional changes

Images/gif

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

)
@Preview(
name = "Tablet Big",
device = Devices.TABLET,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like they removed and the preview didn't work for tablets

@kidinov kidinov requested a review from AnirudhBhat November 26, 2024 08:15
@dangermattic
Copy link
Collaborator

dangermattic commented Nov 26, 2024

2 Warnings
⚠️ Class WooPosIsCashPaymentsEnabled is missing tests, but unit-tests-exemption label was set to ignore this.
⚠️ Class WooPosIsReceiptsEnabled is missing tests, but unit-tests-exemption label was set to ignore this.

Generated by 🚫 Danger

@kidinov kidinov added this to the 21.3 milestone Nov 26, 2024
@kidinov kidinov added the feature: point of sale POS project label Nov 26, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 26, 2024

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit7428acc
Direct Downloadwoocommerce-wear-prototype-build-pr13002-7428acc.apk

@kidinov kidinov changed the title [Woo POS - cash & receipts] Add feature flags for both cash and receipts [Woo POS][Cash & Receipts] Add feature flags for both cash and receipts Nov 26, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 26, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit7428acc
Direct Downloadwoocommerce-prototype-build-pr13002-7428acc.apk

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 39.72%. Comparing base (a43313e) to head (7428acc).

Files with missing lines Patch % Lines
...woopos/featureflags/WooPosIsCashPaymentsEnabled.kt 0.00% 2 Missing ⚠️
.../ui/woopos/featureflags/WooPosIsReceiptsEnabled.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #13002      +/-   ##
============================================
- Coverage     39.72%   39.72%   -0.01%     
  Complexity     6036     6036              
============================================
  Files          1274     1276       +2     
  Lines         73458    73464       +6     
  Branches      10076    10076              
============================================
+ Hits          29181    29183       +2     
- Misses        41701    41705       +4     
  Partials       2576     2576              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AnirudhBhat AnirudhBhat self-assigned this Nov 29, 2024
Copy link
Contributor

@AnirudhBhat AnirudhBhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@AnirudhBhat AnirudhBhat merged commit 639a065 into trunk Nov 29, 2024
15 of 19 checks passed
@AnirudhBhat AnirudhBhat deleted the 12997-woo-poscash-receipts-add-feature-flags-for-both-cash-and-receipts branch November 29, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Woo POS][Cash & Receipts] Add feature flags for both: cash and receipts

6 participants