Skip to content

Conversation

@kidinov
Copy link
Contributor

@kidinov kidinov commented Nov 27, 2024

Closes: #13003

Description

The PR:

  • adds receipt optional button (depends on FF and Woo version)
  • the click on the button opens mock of the receipt sending screen

Testing information

As this largely WIP, the most important here is to validate the there is no regression/changes in the flow when receipts are not available.

To validate the case when it's available:

  • Use debug
  • Either modify WooPosIsReceiptSendingAvailable.WC_VERSION_SUPPORTS_SENDING_RECEIPTS_BY_EMAIL version to the one you have installed or use the Woo store with 9.5.0 version

The tests that have been performed

Aboive

Images/gif

11-27--14-05.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@kidinov kidinov added the feature: point of sale POS project label Nov 27, 2024
@kidinov kidinov added this to the 21.3 milestone Nov 27, 2024
@kidinov kidinov requested a review from samiuelson November 27, 2024 13:11
import com.woocommerce.android.ui.woopos.home.totals.WooPosTotalsViewState

@Composable
fun WooPosTotalsPaymentReceiptScreen(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's just a mock. We have no designs yet

@kidinov kidinov changed the title [Woo POS][Cash & Receipts] Add optional receipt button and empty state for this [Woo POS][Cash & Receipts] Add optional receipt button and receipt sending state mock Nov 27, 2024
@kidinov kidinov changed the title [Woo POS][Cash & Receipts] Add optional receipt button and receipt sending state mock [Woo POS][Cash & Receipts] Add optional receipt button and receipt sending state mock UI Nov 27, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 27, 2024

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit0ca85b5
Direct Downloadwoocommerce-wear-prototype-build-pr13016-0ca85b5.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 27, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit0ca85b5
Direct Downloadwoocommerce-prototype-build-pr13016-0ca85b5.apk

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 39.74%. Comparing base (7428acc) to head (0ca85b5).
Report is 261 commits behind head on trunk.

Files with missing lines Patch % Lines
...oid/ui/woopos/home/totals/WooPosTotalsViewModel.kt 80.00% 0 Missing and 2 partials ⚠️
...payment/receipt/WooPosIsReceiptSendingAvailable.kt 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #13016      +/-   ##
============================================
+ Coverage     39.72%   39.74%   +0.02%     
- Complexity     6036     6041       +5     
============================================
  Files          1276     1277       +1     
  Lines         73464    73495      +31     
  Branches      10076    10081       +5     
============================================
+ Hits          29183    29211      +28     
  Misses        41705    41705              
- Partials       2576     2579       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samiuelson samiuelson self-assigned this Nov 28, 2024
Copy link
Contributor

@samiuelson samiuelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Base automatically changed from 12997-woo-poscash-receipts-add-feature-flags-for-both-cash-and-receipts to trunk November 29, 2024 08:51
@kidinov kidinov merged commit 2ea0c82 into trunk Nov 29, 2024
18 of 20 checks passed
@kidinov kidinov deleted the 13003-woo-pos-cash-receipts-add-optional-receipt-button-and-empty-state-for-this branch November 29, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Woo POS] [Cash & Receipts] Add optional receipt button and empty state for this

5 participants