-
Notifications
You must be signed in to change notification settings - Fork 136
[Woo POS][Cash & Receipts] Add optional receipt button and receipt sending state mock UI #13016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Woo POS][Cash & Receipts] Add optional receipt button and receipt sending state mock UI #13016
Conversation
…ash-and-receipts' into 13003-woo-pos-cash-receipts-add-optional-receipt-button-and-empty-state-for-this # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/totals/WooPosTotalsViewModel.kt # WooCommerce/src/test/kotlin/com/woocommerce/android/ui/woopos/home/totals/WooPosTotalsViewModelTest.kt
| import com.woocommerce.android.ui.woopos.home.totals.WooPosTotalsViewState | ||
|
|
||
| @Composable | ||
| fun WooPosTotalsPaymentReceiptScreen( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's just a mock. We have no designs yet
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #13016 +/- ##
============================================
+ Coverage 39.72% 39.74% +0.02%
- Complexity 6036 6041 +5
============================================
Files 1276 1277 +1
Lines 73464 73495 +31
Branches 10076 10081 +5
============================================
+ Hits 29183 29211 +28
Misses 41705 41705
- Partials 2576 2579 +3 ☔ View full report in Codecov by Sentry. |
samiuelson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Closes: #13003
Description
The PR:
Testing information
As this largely WIP, the most important here is to validate the there is no regression/changes in the flow when receipts are not available.
To validate the case when it's available:
WooPosIsReceiptSendingAvailable.WC_VERSION_SUPPORTS_SENDING_RECEIPTS_BY_EMAILversion to the one you have installed or use the Woo store with 9.5.0 versionThe tests that have been performed
Aboive
Images/gif
11-27--14-05.mp4
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: