Skip to content

Conversation

@irfano
Copy link
Contributor

@irfano irfano commented Nov 27, 2024

Description

The CleanStatusBar feature was not functioning properly. It caused a “!” signal on the Wi-Fi icon and couldn’t change or remove the “3G” icon next to the mobile signal. I removed CleanStatusBar and adjusted the demo mode manually. However, I still couldn’t remove the “3G” icon, so I decided to remove the mobile network icon entirely. I believe the demo mode is not well-maintained for newer Android versions, which is why it’s not working consistently.

Steps to reproduce

Follow the Android Screenshots instructions (P91TBi-8Pt-p2) to test generating promo screenshots. You can test only the en-US locale. Make sure not to miss the new details related to the demo mode mentioned in the instructions.

Testing information

Make sure to generate screenshots with a clean status bar.

The tests that have been performed

Images/gif

before after
image
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@irfano irfano added the category: ui tests Related to UI testing. label Nov 27, 2024
@irfano irfano added this to the 21.3 milestone Nov 27, 2024
@irfano irfano requested a review from a team as a code owner November 27, 2024 22:22
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit40fa56f
Direct Downloadwoocommerce-wear-prototype-build-pr13020-40fa56f.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit40fa56f
Direct Downloadwoocommerce-prototype-build-pr13020-40fa56f.apk

@hafizrahman hafizrahman self-assigned this Nov 28, 2024
@hafizrahman
Copy link
Contributor

Ran into some issue running bundle exec fastlane take_screenshots locales:en-US, asking in Slack p1732764665428189-slack-C03L1NF1EA3

Copy link
Contributor

@hafizrahman hafizrahman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to run the test by making a Pixel 3 API 35 emulator, turning it on first, then running bundle exec fastlane take_screenshots locales:en-US

Status bar looks correct as in the screenshot 👍🏼

@irfano irfano merged commit 6062426 into trunk Nov 28, 2024
17 of 18 checks passed
@irfano irfano deleted the update-clean-status-bar-feature branch November 28, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: ui tests Related to UI testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants