Update clean status bar feature for ScreenshotTest #13020
Merged
+19
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The CleanStatusBar feature was not functioning properly. It caused a “!” signal on the Wi-Fi icon and couldn’t change or remove the “3G” icon next to the mobile signal. I removed CleanStatusBar and adjusted the demo mode manually. However, I still couldn’t remove the “3G” icon, so I decided to remove the mobile network icon entirely. I believe the demo mode is not well-maintained for newer Android versions, which is why it’s not working consistently.
Steps to reproduce
Follow the Android Screenshots instructions (P91TBi-8Pt-p2) to test generating promo screenshots. You can test only the en-US locale. Make sure not to miss the new details related to the demo mode mentioned in the instructions.
Testing information
Make sure to generate screenshots with a clean status bar.
The tests that have been performed
Images/gif
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: