-
Notifications
You must be signed in to change notification settings - Fork 136
Improve logic to display "One time shipping" label on Product Details #13021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…whether it is currently supported.
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #13021 +/- ##
=========================================
Coverage 40.13% 40.13%
- Complexity 6119 6120 +1
=========================================
Files 1280 1280
Lines 74006 74008 +2
Branches 10123 10122 -1
=========================================
+ Hits 29701 29703 +2
Misses 41725 41725
Partials 2580 2580 ☔ View full report in Codecov by Sentry. |
irfano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for clearly explaining the rationale behind the change. LGTM and works as expected. 👍🏻 I’m approving but not merging to give you a chance to consider my suggestion regarding code style.
I also noticed another issue with the "One time shipping" label: #13027. It's reproducable on trunk and outside the scope of this PR.
...erce/src/main/kotlin/com/woocommerce/android/ui/products/details/ProductDetailCardBuilder.kt
Outdated
Show resolved
Hide resolved
Thanks! I'll take a look at that issue next. |
Closes: #12785
Description
This PR deals with the "One time shipping" feature in Subscription Product and the way its state is displayed in Product Details screen.
The documentation states this:
This PR updates the Android behavior to match iOS:
Steps to reproduce
Optionally, also test this with an existing Product. The behavior should be the same.
Testing information
I tested this in an emulator with both new simple subscription product and existing product.
The tests that have been performed
Everything in the list above.
Images/gif
Expected states:
Screen_recording_20241128_153843.mp4
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: