Skip to content

Conversation

@toupper
Copy link
Contributor

@toupper toupper commented Nov 28, 2024

Closes: #13025

Description

With this PR we show the global unique id values in the product and variation detail screens.

Steps to reproduce

With a product or variation containing a global unique id

  1. Go to products
  2. Tap on a product containing a global unique id
  3. See that the value is shown in the inventory card below the SKU. Repeat the process for variations.

Testing information

The tests that have been performed

I also checked that it's shown for external products.

Images/gif

Products

Variations

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@toupper toupper added type: task An internally driven task. feature: product details Related to adding or editing products, includes product settings. labels Nov 28, 2024
@toupper toupper added this to the 21.3 milestone Nov 28, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 28, 2024

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitdfbbf55
Direct Downloadwoocommerce-wear-prototype-build-pr13026-dfbbf55.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 28, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitdfbbf55
Direct Downloadwoocommerce-prototype-build-pr13026-dfbbf55.apk

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 40.34%. Comparing base (509b9c9) to head (dfbbf55).
Report is 5 commits behind head on trunk.

Files with missing lines Patch % Lines
...id/ui/products/details/ProductDetailCardBuilder.kt 0.00% 1 Missing and 1 partial ⚠️
.../products/variations/VariationDetailCardBuilder.kt 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##              trunk   #13026   +/-   ##
=========================================
  Coverage     40.34%   40.34%           
- Complexity     6160     6161    +1     
=========================================
  Files          1287     1287           
  Lines         74152    74156    +4     
  Branches      10142    10143    +1     
=========================================
+ Hits          29913    29915    +2     
- Misses        41649    41651    +2     
  Partials       2590     2590           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@toupper toupper merged commit 4a8ef34 into trunk Dec 2, 2024
15 checks passed
@toupper toupper deleted the issue/13025-product-global-unique-id-product-details branch December 2, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: product details Related to adding or editing products, includes product settings. type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add value in Product Details (Main View)

4 participants