Skip to content

Conversation

@ThomazFB
Copy link
Contributor

@ThomazFB ThomazFB commented Nov 28, 2024

Summary

Partially fix issue #12284 by completing the Package mapping and wiring from the networking request into the UI, but without the full JSON serialization from the network layer.

The next PR will finish the entire data acquisition flow and will require a reviewer.

How to Test

  1. This is not testable as it is; since the code is unreachable from the UI, there's only a unit test covering it.

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@dangermattic
Copy link
Collaborator

dangermattic commented Nov 28, 2024

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 28, 2024

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit4d99c06
Direct Downloadwoocommerce-wear-prototype-build-pr13028-4d99c06.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 28, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit4d99c06
Direct Downloadwoocommerce-prototype-build-pr13028-4d99c06.apk

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 68.79433% with 44 lines in your changes missing coverage. Please review.

Project coverage is 39.81%. Comparing base (95ad84b) to head (4d99c06).
Report is 305 commits behind head on trunk.

Files with missing lines Patch % Lines
...i/orders/wooshippinglabels/packages/ui/UIModels.kt 54.71% 23 Missing and 1 partial ⚠️
...ckages/datasource/WooShippingLabelPackageMapper.kt 0.00% 15 Missing ⚠️
.../packages/components/WooShippingPackageListItem.kt 0.00% 2 Missing ⚠️
...ges/datasource/FetchPredefinedPackagesFromStore.kt 95.55% 0 Missing and 2 partials ⚠️
...oshippinglabels/packages/datasource/PackageDAOs.kt 93.75% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #13028      +/-   ##
============================================
+ Coverage     39.72%   39.81%   +0.08%     
- Complexity     6036     6046      +10     
============================================
  Files          1274     1274              
  Lines         73453    73441      -12     
  Branches      10074    10083       +9     
============================================
+ Hits          29177    29237      +60     
+ Misses        41701    41626      -75     
- Partials       2575     2578       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThomazFB ThomazFB added type: task An internally driven task. feature: shipping labels Related to creating, ordering, or printing shipping labels. labels Nov 29, 2024
@ThomazFB ThomazFB added this to the 21.3 milestone Nov 29, 2024
@ThomazFB ThomazFB linked an issue Nov 29, 2024 that may be closed by this pull request
@ThomazFB ThomazFB marked this pull request as ready for review November 29, 2024 19:46
@ThomazFB ThomazFB merged commit d44f104 into trunk Nov 29, 2024
24 checks passed
@ThomazFB ThomazFB deleted the issue/wire-package-networking-with-UI branch November 29, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: shipping labels Related to creating, ordering, or printing shipping labels. type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get list of packages

5 participants