-
Notifications
You must be signed in to change notification settings - Fork 136
[Shipping Labels Revamp] Wire package networking with UI #13028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ngLabelPackageRepository
…ackage response from use case
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
…esponse during errors
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #13028 +/- ##
============================================
+ Coverage 39.72% 39.81% +0.08%
- Complexity 6036 6046 +10
============================================
Files 1274 1274
Lines 73453 73441 -12
Branches 10074 10083 +9
============================================
+ Hits 29177 29237 +60
+ Misses 41701 41626 -75
- Partials 2575 2578 +3 ☔ View full report in Codecov by Sentry. |
…o Custom packages
Summary
Partially fix issue #12284 by completing the Package mapping and wiring from the networking request into the UI, but without the full JSON serialization from the network layer.
The next PR will finish the entire data acquisition flow and will require a reviewer.
How to Test
Update release notes:
RELEASE-NOTES.txtif necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: