-
Notifications
You must be signed in to change notification settings - Fork 136
Connecting shipping lines #13029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connecting shipping lines #13029
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #13029 +/- ##
============================================
+ Coverage 39.75% 39.84% +0.09%
- Complexity 6049 6069 +20
============================================
Files 1278 1278
Lines 73584 73600 +16
Branches 10084 10084
============================================
+ Hits 29250 29325 +75
+ Misses 41753 41692 -61
- Partials 2581 2583 +2 ☔ View full report in Codecov by Sentry. |
ThomazFB
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and working as described 🫡 Looks good!
Part of: #12998
Description
This PR connects the shipping lines section inside the shipment details bottom sheet with real data (order's shipping lines).
To achieve this, I'm mapping the shipping lines from the order into ShippingLineSumary and exposing them to the view state.
Testing information
TC1
TC2
The tests that have been performed
Checking the UI works as expected
Images/gif
Screen_recording_20241128_203718.mp4
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: