[Woo POS][Cash & Receipts] Update customer with email and use action to send it #13034

kidinov · 2024-11-29T13:19:12Z

Closes: #13031

Description

The PR adds calling of the two endpoints:

One to update an email of the order
The second to call action that uses that email to send order details

Testing information

Use flipper to monitor network request
Use the 9.5.0 beta version of the Woo Core
POS -> Make an order
Receipts
Send a receipt to an email you use
Validate network calls in flipper

I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

kidinov · 2024-11-29T13:20:18Z

...merce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/totals/WooPosTotalsViewModel.kt

+        val orderId = dataState.value.orderId
+        check(orderId != EMPTY_ORDER_ID)
+        viewModelScope.launch {
+            receiptRepository.sendReceiptByEmail(orderId, email)


We have no designs, so no handling of the error or success in this PR

❓ Do we have plans to validate the email ids here?

It depends on the UI, I don't know

wpmobilebot · 2024-11-29T13:26:22Z

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`a7145f2`
	Direct Download	`woocommerce-wear-prototype-build-pr13034-a7145f2.apk`

wpmobilebot · 2024-11-29T13:36:06Z

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`a7145f2`
	Direct Download	`woocommerce-prototype-build-pr13034-a7145f2.apk`

AnirudhBhat

Thanks for working on this. The API calls are being made as expected. I noticed that we are not validating entered text in the email field which results in making unnecessary API calls that always fails when entered some random text.

AnirudhBhat · 2024-12-02T10:53:21Z

...merce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/totals/WooPosTotalsViewModel.kt

+        val orderId = dataState.value.orderId
+        check(orderId != EMPTY_ORDER_ID)
+        viewModelScope.launch {
+            receiptRepository.sendReceiptByEmail(orderId, email)


❓ Do we have plans to validate the email ids here?

…with-email-and-use-action-to-send-it # Conflicts: # gradle/libs.versions.toml

wpmobilebot · 2024-12-03T08:14:47Z

Project dependencies changes

The following changes in project dependencies were detected (configuration vanillaReleaseRuntimeClasspath):

list

Upgraded Dependencies
org.wordpress.fluxc.plugins:woocommerce:trunk-b06ca0ea66c6515813be7c59c83c7e1f0b0c6738, (changed from trunk-3d4558601eaa4fc1d4a0254c6caff5f7c87732bb)
org.wordpress.fluxc:fluxc-annotations:trunk-b06ca0ea66c6515813be7c59c83c7e1f0b0c6738, (changed from trunk-3d4558601eaa4fc1d4a0254c6caff5f7c87732bb)
org.wordpress:fluxc:trunk-b06ca0ea66c6515813be7c59c83c7e1f0b0c6738, (changed from trunk-3d4558601eaa4fc1d4a0254c6caff5f7c87732bb)

tree

-+--- org.wordpress:fluxc:trunk-3d4558601eaa4fc1d4a0254c6caff5f7c87732bb
-|    +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.25 -> 2.0.21
-|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 (*)
-|    |    \--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:2.0.21
-|    |         \--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 (*)
-|    +--- androidx.exifinterface:exifinterface:1.0.0 -> 1.3.6
-|    |    \--- androidx.annotation:annotation:1.2.0 -> 1.8.0 (*)
-|    +--- androidx.security:security-crypto:1.0.0 -> 1.1.0-alpha03
-|    |    +--- androidx.annotation:annotation:1.1.0 -> 1.8.0 (*)
-|    |    +--- com.google.crypto.tink:tink-android:1.5.0
-|    |    \--- androidx.collection:collection:1.1.0 -> 1.4.0 (*)
-|    +--- com.squareup.okhttp3:okhttp-urlconnection:4.9.0
-|    |    +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.12.0 (*)
-|    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.10 -> 1.9.10 (*)
-|    +--- com.google.code.gson:gson:2.8.5 -> 2.10.1
-|    +--- org.apache.commons:commons-text:1.10.0 (*)
-|    +--- androidx.room:room-runtime:2.6.1 (*)
-|    +--- androidx.room:room-ktx:2.6.1
-|    |    +--- androidx.room:room-common:2.6.1 (*)
-|    |    +--- androidx.room:room-runtime:2.6.1 (*)
-|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.21 (*)
-|    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.7.1 -> 1.8.1 (*)
-|    |    +--- androidx.room:room-common:2.6.1 (c)
-|    |    \--- androidx.room:room-runtime:2.6.1 (c)
-|    +--- com.google.dagger:dagger:2.51.1
-|    |    \--- javax.inject:javax.inject:1
-|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.8.1 (*)
-|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.8.1 (*)
-|    +--- org.wordpress:wellsql:2.0.0
-|    |    +--- androidx.annotation:annotation:1.2.0 -> 1.8.0 (*)
-|    |    \--- org.wordpress.wellsql:wellsql-annotations:2.0.0
-|    +--- org.wordpress.fluxc:fluxc-annotations:trunk-3d4558601eaa4fc1d4a0254c6caff5f7c87732bb
-|    +--- org.greenrobot:eventbus:3.3.1 (*)
-|    +--- org.greenrobot:eventbus-java:3.3.1
-|    +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.12.0 (*)
-|    +--- com.android.volley:volley:1.1.1 -> 1.2.0
-|    +--- androidx.paging:paging-runtime:2.1.2
-|    |    +--- androidx.paging:paging-common:2.1.2
-|    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.8.0 (*)
-|    |    |    \--- androidx.arch.core:core-common:2.0.0 -> 2.2.0 (*)
-|    |    +--- androidx.arch.core:core-runtime:2.0.0 -> 2.2.0 (*)
-|    |    +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.7.0 (*)
-|    |    +--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.7.0 (*)
-|    |    \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.2 (*)
-|    +--- com.goterl:lazysodium-android:5.0.2
-|    +--- net.java.dev.jna:jna:5.5.0
-|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.25 -> 2.0.21 (*)
++--- org.wordpress:fluxc:trunk-b06ca0ea66c6515813be7c59c83c7e1f0b0c6738
+|    +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.25 -> 2.0.21
+|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 (*)
+|    |    \--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:2.0.21
+|    |         \--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 (*)
+|    +--- androidx.exifinterface:exifinterface:1.0.0 -> 1.3.6
+|    |    \--- androidx.annotation:annotation:1.2.0 -> 1.8.0 (*)
+|    +--- androidx.security:security-crypto:1.0.0 -> 1.1.0-alpha03
+|    |    +--- androidx.annotation:annotation:1.1.0 -> 1.8.0 (*)
+|    |    +--- com.google.crypto.tink:tink-android:1.5.0
+|    |    \--- androidx.collection:collection:1.1.0 -> 1.4.0 (*)
+|    +--- com.squareup.okhttp3:okhttp-urlconnection:4.9.0
+|    |    +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.12.0 (*)
+|    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.10 -> 1.9.10 (*)
+|    +--- com.google.code.gson:gson:2.8.5 -> 2.10.1
+|    +--- org.apache.commons:commons-text:1.10.0 (*)
+|    +--- androidx.room:room-runtime:2.6.1 (*)
+|    +--- androidx.room:room-ktx:2.6.1
+|    |    +--- androidx.room:room-common:2.6.1 (*)
+|    |    +--- androidx.room:room-runtime:2.6.1 (*)
+|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.21 (*)
+|    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.7.1 -> 1.8.1 (*)
+|    |    +--- androidx.room:room-common:2.6.1 (c)
+|    |    \--- androidx.room:room-runtime:2.6.1 (c)
+|    +--- com.google.dagger:dagger:2.51.1
+|    |    \--- javax.inject:javax.inject:1
+|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.8.1 (*)
+|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.8.1 (*)
+|    +--- org.wordpress:wellsql:2.0.0
+|    |    +--- androidx.annotation:annotation:1.2.0 -> 1.8.0 (*)
+|    |    \--- org.wordpress.wellsql:wellsql-annotations:2.0.0
+|    +--- org.wordpress.fluxc:fluxc-annotations:trunk-b06ca0ea66c6515813be7c59c83c7e1f0b0c6738
+|    +--- org.greenrobot:eventbus:3.3.1 (*)
+|    +--- org.greenrobot:eventbus-java:3.3.1
+|    +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.12.0 (*)
+|    +--- com.android.volley:volley:1.1.1 -> 1.2.0
+|    +--- androidx.paging:paging-runtime:2.1.2
+|    |    +--- androidx.paging:paging-common:2.1.2
+|    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.8.0 (*)
+|    |    |    \--- androidx.arch.core:core-common:2.0.0 -> 2.2.0 (*)
+|    |    +--- androidx.arch.core:core-runtime:2.0.0 -> 2.2.0 (*)
+|    |    +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.7.0 (*)
+|    |    +--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.7.0 (*)
+|    |    \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.2 (*)
+|    +--- com.goterl:lazysodium-android:5.0.2
+|    +--- net.java.dev.jna:jna:5.5.0
+|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.25 -> 2.0.21 (*)
-\--- org.wordpress.fluxc.plugins:woocommerce:trunk-3d4558601eaa4fc1d4a0254c6caff5f7c87732bb
-     +--- org.wordpress:fluxc:trunk-3d4558601eaa4fc1d4a0254c6caff5f7c87732bb (*)
-     +--- com.google.code.gson:gson:2.8.5 -> 2.10.1
-     +--- com.google.dagger:dagger:2.51.1 (*)
-     +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.8.1 (*)
-     +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.8.1 (*)
-     +--- androidx.room:room-runtime:2.6.1 (*)
-     +--- org.wordpress:wellsql:2.0.0 (*)
-     +--- org.wordpress.fluxc:fluxc-annotations:trunk-3d4558601eaa4fc1d4a0254c6caff5f7c87732bb
-     +--- androidx.room:room-ktx:2.6.1 (*)
-     \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.25 -> 2.0.21 (*)
+\--- org.wordpress.fluxc.plugins:woocommerce:trunk-b06ca0ea66c6515813be7c59c83c7e1f0b0c6738
+     +--- org.wordpress:fluxc:trunk-b06ca0ea66c6515813be7c59c83c7e1f0b0c6738 (*)
+     +--- com.google.code.gson:gson:2.8.5 -> 2.10.1
+     +--- com.google.dagger:dagger:2.51.1 (*)
+     +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.8.1 (*)
+     +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.8.1 (*)
+     +--- androidx.room:room-runtime:2.6.1 (*)
+     +--- org.wordpress:wellsql:2.0.0 (*)
+     +--- org.wordpress.fluxc:fluxc-annotations:trunk-b06ca0ea66c6515813be7c59c83c7e1f0b0c6738
+     +--- androidx.room:room-ktx:2.6.1 (*)
+     \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.25 -> 2.0.21 (*)

codecov-commenter · 2024-12-03T08:32:45Z

Codecov Report

Attention: Patch coverage is 58.53659% with 17 lines in your changes missing coverage. Please review.

Project coverage is 40.34%. Comparing base (4a8ef34) to head (a7145f2).
Report is 13 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...oid/ui/woopos/home/totals/WooPosTotalsViewModel.kt	15.38%	10 Missing and 1 partial ⚠️
...nt/receipt/WooPosTotalsPaymentReceiptRepository.kt	80.76%	1 Missing and 4 partials ⚠️
...droid/ui/woopos/home/totals/WooPosTotalsUIEvent.kt	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##              trunk   #13034   +/-   ##
=========================================
  Coverage     40.34%   40.34%           
- Complexity     6161     6167    +6     
=========================================
  Files          1287     1288    +1     
  Lines         74156    74194   +38     
  Branches      10143    10152    +9     
=========================================
+ Hits          29915    29935   +20     
- Misses        41651    41663   +12     
- Partials       2590     2596    +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kidinov added 8 commits November 29, 2024 09:46

Fluxc with the action to send an email

479f86e

Renamed availability checker to follow the convention

421f9ee

Call repository when a button clicked

d471c83

Fixed naming

62e345e

Update email state

06789da

Code that updates email and sends order details there

275f1c7

Simplified the code

5eff1cc

Update billing address

2435dde

kidinov added the feature: point of sale POS project label Nov 29, 2024

kidinov added this to the 21.3 milestone Nov 29, 2024

kidinov requested a review from AnirudhBhat November 29, 2024 13:19

kidinov linked an issue Nov 29, 2024 that may be closed by this pull request

[Woo POS][Cash & Receipts] Update customer with email and use action to send it #13031

Closed

kidinov marked this pull request as draft November 29, 2024 13:19

kidinov commented Nov 29, 2024

View reviewed changes

kidinov added 2 commits November 29, 2024 15:58

WooPosTotalsPaymentReceiptRepositoryTest

18a93ac

Fixed formatting

2f67f6f

kidinov marked this pull request as ready for review November 29, 2024 15:14

AnirudhBhat self-assigned this Dec 2, 2024

AnirudhBhat approved these changes Dec 2, 2024

View reviewed changes

kidinov added 2 commits December 3, 2024 09:06

Point fluxc to trunk

667a1b8

Merge branch 'trunk' into 13031-woo-poscash-receipts-update-customer-…

a7145f2

…with-email-and-use-action-to-send-it # Conflicts: # gradle/libs.versions.toml

kidinov enabled auto-merge December 3, 2024 08:11

kidinov merged commit 90ca750 into trunk Dec 3, 2024
15 checks passed

kidinov deleted the 13031-woo-poscash-receipts-update-customer-with-email-and-use-action-to-send-it branch December 3, 2024 08:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Woo POS][Cash & Receipts] Update customer with email and use action to send it #13034

[Woo POS][Cash & Receipts] Update customer with email and use action to send it #13034

Uh oh!

kidinov commented Nov 29, 2024 •

edited by AnirudhBhat

Loading

Uh oh!

kidinov Nov 29, 2024

Uh oh!

AnirudhBhat Dec 2, 2024

Uh oh!

kidinov Dec 2, 2024

Uh oh!

wpmobilebot commented Nov 29, 2024 •

edited

Loading

Uh oh!

wpmobilebot commented Nov 29, 2024 •

edited

Loading

Uh oh!

AnirudhBhat left a comment •

edited

Loading

Uh oh!

AnirudhBhat Dec 2, 2024

Uh oh!

wpmobilebot commented Dec 3, 2024

Uh oh!

Uh oh!

codecov-commenter commented Dec 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[Woo POS][Cash & Receipts] Update customer with email and use action to send it #13034

[Woo POS][Cash & Receipts] Update customer with email and use action to send it #13034

Uh oh!

Conversation

kidinov commented Nov 29, 2024 • edited by AnirudhBhat Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing information

Reviewer (or Author, in the case of optional code reviews):

Uh oh!

kidinov Nov 29, 2024

Choose a reason for hiding this comment

Uh oh!

AnirudhBhat Dec 2, 2024

Choose a reason for hiding this comment

Uh oh!

kidinov Dec 2, 2024

Choose a reason for hiding this comment

Uh oh!

wpmobilebot commented Nov 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Nov 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AnirudhBhat left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AnirudhBhat Dec 2, 2024

Choose a reason for hiding this comment

Uh oh!

wpmobilebot commented Dec 3, 2024

Project dependencies changes

Uh oh!

Uh oh!

codecov-commenter commented Dec 3, 2024

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kidinov commented Nov 29, 2024 •

edited by AnirudhBhat

Loading

wpmobilebot commented Nov 29, 2024 •

edited

Loading

wpmobilebot commented Nov 29, 2024 •

edited

Loading

AnirudhBhat left a comment •

edited

Loading