-
Notifications
You must be signed in to change notification settings - Fork 136
Fix design issues #13205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix design issues #13205
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #13205 +/- ##
============================================
- Coverage 40.62% 40.61% -0.01%
Complexity 6367 6367
============================================
Files 1345 1345
Lines 77240 77245 +5
Branches 10603 10604 +1
============================================
Hits 31376 31376
- Misses 43105 43110 +5
Partials 2759 2759 ☔ View full report in Codecov by Sentry. |
ThomazFB
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Nice adjustments 😄
Description
This PR fixes some minor design issues on the shipping label support for the M1.
1. Fix badge position
This change updates the top alignment of the quantity badge. d7dddc4
2. Add nav back support
Add support for back navigation using the Toolbar. Fixed here 1929f5a
Screen_recording_20241225_213608.mp4
3. Carrier divider using the screen width
This change updates the carrier's tab divider to use the screen width. 99e5603
4. Fix custom weight dark mode
This change fixes dark mode support for the custom weight text field 89c70ba
5. Fix incorrect padding
This change fixes the bottom padding when there is no information about shipping rates (the purchase button is not yet visible) d423bf1
Testing information
TC1
TC2
TC3
TC4
TC5
The tests that have been performed
Checking that the UI works as expected
I have considered if this change warrants release notes and have added them to
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: