Skip to content

Conversation

@atorresveiga
Copy link
Contributor

@atorresveiga atorresveiga commented Dec 25, 2024

Description

This PR fixes some minor design issues on the shipping label support for the M1.

1. Fix badge position

This change updates the top alignment of the quantity badge. d7dddc4

Before After

2. Add nav back support

Add support for back navigation using the Toolbar. Fixed here 1929f5a

Screen_recording_20241225_213608.mp4

3. Carrier divider using the screen width

This change updates the carrier's tab divider to use the screen width. 99e5603

Before After

4. Fix custom weight dark mode

This change fixes dark mode support for the custom weight text field 89c70ba

Before After

5. Fix incorrect padding

This change fixes the bottom padding when there is no information about shipping rates (the purchase button is not yet visible) d423bf1

Before After

Testing information

TC1

  1. Open the orders section
  2. Open an order eligible for shipping label creation
  3. Expand the products section
  4. Check the quantity badge position

TC2

  1. Open the orders section
  2. Open an order eligible for shipping label creation
  3. Tap on the back arrow in the Toolbar
  4. Check that the app navigates to the order details screen

TC3

  1. Open the orders section
  2. Open an order eligible for shipping label creation
  3. Select a package
  4. Check that the carrier tab divider matches the screen width

TC4

  1. Open the orders section
  2. Open an order eligible for shipping label creation
  3. Select a package
  4. Turn on dark mode
  5. Type a value on the custom weight
  6. Check that the value is visible

TC5

  1. Open the orders section
  2. Open an order eligible for shipping label creation
  3. Expand the shipment section
  4. Check that the mark order complete control does not have an unnecessary margin

The tests that have been performed

  • Checking that the UI works as expected

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 25, 2024

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit5af3d2f
Direct Downloadwoocommerce-wear-prototype-build-pr13205-5af3d2f.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 25, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit5af3d2f
Direct Downloadwoocommerce-prototype-build-pr13205-5af3d2f.apk

@codecov-commenter
Copy link

codecov-commenter commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 40.61%. Comparing base (c421fdd) to head (5af3d2f).
Report is 23 commits behind head on trunk.

Files with missing lines Patch % Lines
...hippinglabels/WooShippingLabelCreationViewModel.kt 0.00% 2 Missing ⚠️
...rs/wooshippinglabels/rates/ui/ShippingRatesCard.kt 0.00% 2 Missing ⚠️
...rders/wooshippinglabels/WooShippingProductsCard.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #13205      +/-   ##
============================================
- Coverage     40.62%   40.61%   -0.01%     
  Complexity     6367     6367              
============================================
  Files          1345     1345              
  Lines         77240    77245       +5     
  Branches      10603    10604       +1     
============================================
  Hits          31376    31376              
- Misses        43105    43110       +5     
  Partials       2759     2759              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atorresveiga atorresveiga added type: enhancement A request for an enhancement. feature: shipping labels Related to creating, ordering, or printing shipping labels. labels Dec 26, 2024
@atorresveiga atorresveiga added this to the 21.4 milestone Dec 26, 2024
@atorresveiga atorresveiga marked this pull request as ready for review December 26, 2024 02:23
@ThomazFB ThomazFB self-assigned this Dec 26, 2024
Copy link
Contributor

@ThomazFB ThomazFB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice adjustments 😄

@atorresveiga atorresveiga merged commit b34b06d into trunk Dec 27, 2024
16 checks passed
@atorresveiga atorresveiga deleted the issue/fix-desing-issues branch December 27, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: shipping labels Related to creating, ordering, or printing shipping labels. type: enhancement A request for an enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants