Skip to content

Conversation

@kidinov
Copy link
Contributor

@kidinov kidinov commented Jan 7, 2025

Description

As there is no clarity on when exactly and how the crash was happening, I think it's better to have highly unluckily ANR than slightly more highly likely crash, so removing the delay

peaMlT-14I-p2#comment-2738

Testing information

Test different cases of the opening order details:

  • From notification
  • From the app

Try Pull to refresh and open it, and so on

The tests that have been performed

above

Images/gif

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@kidinov kidinov added the type: crash The worst kind of bug. label Jan 7, 2025
@kidinov kidinov added this to the 21.4 milestone Jan 7, 2025
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitfc95075
Direct Downloadwoocommerce-wear-prototype-build-pr13251-fc95075.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitfc95075
Direct Downloadwoocommerce-prototype-build-pr13251-fc95075.apk

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.59%. Comparing base (a816f76) to head (fc95075).
Report is 41 commits behind head on trunk.

Additional details and impacted files
@@            Coverage Diff            @@
##              trunk   #13251   +/-   ##
=========================================
  Coverage     40.59%   40.59%           
- Complexity     6388     6389    +1     
=========================================
  Files          1351     1351           
  Lines         77645    77642    -3     
  Branches      10679    10679           
=========================================
  Hits          31517    31517           
+ Misses        43345    43343    -2     
+ Partials       2783     2782    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AnirudhBhat AnirudhBhat self-assigned this Jan 8, 2025
Copy link
Contributor

@AnirudhBhat AnirudhBhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@AnirudhBhat AnirudhBhat merged commit c440db9 into trunk Jan 8, 2025
18 of 20 checks passed
@AnirudhBhat AnirudhBhat deleted the remove-timeout-order-details branch January 8, 2025 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: crash The worst kind of bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants