-
Notifications
You must be signed in to change notification settings - Fork 136
[Android SDK] Update compile SDK to 35 #13271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
…-to-35' into 13269-android-sdk-update-min-sdk-to-35
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
…ndroid API below 15
…I level 35 (current min is 26): java.util.List#removeFirst [NewApi]"
…oid-sdk-update-min-sdk-to-35-bottomsheet-fixes
…oid-sdk-update-min-sdk-to-35-bottomsheet-fixes
…oid-sdk-update-min-sdk-to-35-bottomsheet-fixes
…oid-sdk-update-min-sdk-to-35-bottomsheet-fixes
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #13271 +/- ##
============================================
- Coverage 41.10% 41.09% -0.01%
+ Complexity 6421 6420 -1
============================================
Files 1321 1320 -1
Lines 77177 77193 +16
Branches 10643 10644 +1
============================================
- Hits 31722 31721 -1
- Misses 42646 42662 +16
- Partials 2809 2810 +1 ☔ View full report in Codecov by Sentry. |
…in-sdk-to-35-bottomsheet-fixes [Android SDK update] Bottom sheet fixes
…-to-35' into 13269-android-sdk-update-min-sdk-to-35
samiuelson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes: #13269
Description
The PR updates compile SDK version to 35 and brings the changes necessary to do so
There are a few of APIs that got deprecated:
Window.statusBarColorWindow.navigationBarColorTherefore there are changes related to it in
WCModalBottomSheetLayoutbut they were reviewed already - [Android SDK update] Bottom sheet fixes #13285, so feel free to ignore those changes in the reviewThe changes in the WooPOS are done by tweaking the theme. Validate that there are no visual changes regarding the colors
onLowMemorymarked as deprecated in the parent class so I just markedremoveFirstreplaced withremoveAtdue to https://issuetracker.google.com/issues/350432371Testing information
Green CI should be enough, but just for sake of safety check Blaze related functionality and it's bottoms sheets as well as Woo POS
The tests that have been performed
Above
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: