-
Notifications
You must be signed in to change notification settings - Fork 136
Remove shipping labels survey #13319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #13319 +/- ##
============================================
- Coverage 41.10% 41.10% -0.01%
Complexity 6420 6420
============================================
Files 1321 1321
Lines 77177 77173 -4
Branches 10644 10645 +1
============================================
- Hits 31721 31719 -2
+ Misses 42646 42644 -2
Partials 2810 2810 ☔ View full report in Codecov by Sentry. |
JorgeMucientes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup! Works as expected 👍🏼 ![]()
RELEASE-NOTES.txt
Outdated
| ----- | ||
| - [*] Fixes missing text in Blaze Campaigns card on larger display and font sizes [https://github.com/woocommerce/woocommerce-android/pull/13300] | ||
| - [*] Puerto Rico is now available in the list of countries that are supported by in-person payments [https://github.com/woocommerce/woocommerce-android/pull/13200] | ||
| - [*] Removed an outdated feedback survey [https://github.com/woocommerce/woocommerce-android/pull/13319] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe be more specific about the survey being related to shipping labels?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 Done: 10fd033
Part of: #13012
Description
This removes shipping labels survey from the order detail screen.
Rationale: pe5sF9-3GX-p2
Steps to reproduce
trunkbranch. (You can use the order 530 on the IPP testing site that mentioned here, P91TBi-bVe-p2)The tests that have been performed
Steps above
Images/gif
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: