Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Order List]Ensure First Order is Selected When Filtering is Active #13491

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

AnirudhBhat
Copy link
Contributor

Closes: #13490

Description

This PR fixes a bug where no orders were being selected when filtering was active.

Steps to reproduce

  1. Navigate to order list in tablet or 2 pane layout
  2. Apply filtering
  3. Observe that first order is not selected automatically

Testing information

Ensure first order is selected automatically

  1. Navigate to order list in tablet or 2 pane layout
  2. Apply filtering
  3. Observe that first order is selected automatically

Ensure selected order is retained when pull to refresh while filtering is active

  1. Navigate to order list in tablet or 2 pane layout
  2. Apply filtering
  3. Observe that first order is selected automatically
  4. Select any other order
  5. Pull to refresh
  6. Observe that the selected order is retained

Ensure first order is selected when filtering option is changed

  1. Navigate to order list in tablet or 2 pane layout
  2. Apply filtering
  3. Observe that first order is selected automatically
  4. Select any other order
  5. Change the filtering criteria
  6. Observe that first order is selected automatically

The tests that have been performed

Above

Images/gif

two-pane-layout-filtering-bug.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@AnirudhBhat AnirudhBhat added type: bug A confirmed bug. feature: order list Related to the order list. category: tablet Specific to tablet devices such as a Galaxy Tab or an iPad. labels Feb 7, 2025
@AnirudhBhat AnirudhBhat added this to the 21.7 milestone Feb 7, 2025
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 21.7. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit12e8792
Direct Downloadwoocommerce-wear-prototype-build-pr13491-12e8792.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit12e8792
Direct Downloadwoocommerce-prototype-build-pr13491-12e8792.apk

@wpmobilebot wpmobilebot modified the milestones: 21.7, 21.8 Feb 7, 2025
@wpmobilebot
Copy link
Collaborator

Version 21.7 has now entered code-freeze, so the milestone of this PR has been updated to 21.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tablet Specific to tablet devices such as a Galaxy Tab or an iPad. feature: order list Related to the order list. type: bug A confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Order List][Tablet] Applying a Filter in Two-Pane Layout Doesn’t Automatically Select the First Order
3 participants