-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authenticated WebView improvement [Part 3] #13505
Open
hichamboushaba
wants to merge
4
commits into
trunk
Choose a base branch
from
issue/13467-improve-authenticated-webview-3
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+116
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
d04c5c1
to
80506c6
Compare
4 tasks
Base automatically changed from
issue/13467-improve-authenticated-webview-2
to
trunk
February 12, 2025 17:54
@Hicham, if the product visibility is private, "View product on store" button becomes invisible. Is the instruction wrong? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status: do not merge
Dependent on another PR, ready for review but not ready for merge.
type: enhancement
A request for an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #13467
Description
This PR builds on top of what was added in #13487 and adds an additional handling for WebView authentication to the atomic sites, it fixes an issue that I identified while testing the Product Previews in #13494, for more details on the issue itself check: pe5sF9-3QB-p2#comment-4374.
For the fix, now we do the following for non-admin URLs:
With this PR, we now implement the whole flow as represented in this document pe5sF9-3Si-p2
Steps to reproduce
For testing, please test the TC1 in #13494 using an Atomic website.
Testing information
Confirm that the Authenticated WebView works well with non-admin URLs in atomic websites.
The tests that have been performed
^
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: