Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authenticated WebView improvement [Part 3] #13505

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

hichamboushaba
Copy link
Member

@hichamboushaba hichamboushaba commented Feb 7, 2025

Closes: #13467

Description

This PR builds on top of what was added in #13487 and adds an additional handling for WebView authentication to the atomic sites, it fixes an issue that I identified while testing the Product Previews in #13494, for more details on the issue itself check: pe5sF9-3QB-p2#comment-4374.

For the fix, now we do the following for non-admin URLs:

  1. We handle the Bearer token authentication with WordPress.com.
  2. Then we load the site login URL with the redirect.

With this PR, we now implement the whole flow as represented in this document pe5sF9-3Si-p2

Steps to reproduce

For testing, please test the TC1 in #13494 using an Atomic website.

Testing information

Confirm that the Authenticated WebView works well with non-admin URLs in atomic websites.

The tests that have been performed

^

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@hichamboushaba hichamboushaba added type: enhancement A request for an enhancement. status: do not merge Dependent on another PR, ready for review but not ready for merge. labels Feb 7, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Feb 7, 2025

2 Errors
🚫 This PR is tagged with status: do not merge label(s).
🚫 PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Feb 7, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit80506c6
Direct Downloadwoocommerce-wear-prototype-build-pr13505-80506c6.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Feb 7, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit80506c6
Direct Downloadwoocommerce-prototype-build-pr13505-80506c6.apk

@hichamboushaba hichamboushaba force-pushed the issue/13467-improve-authenticated-webview-3 branch from d04c5c1 to 80506c6 Compare February 7, 2025 18:17
@hichamboushaba hichamboushaba marked this pull request as ready for review February 10, 2025 13:48
Base automatically changed from issue/13467-improve-authenticated-webview-2 to trunk February 12, 2025 17:54
@irfano irfano self-assigned this Feb 13, 2025
@irfano
Copy link
Contributor

irfano commented Feb 14, 2025

  1. Change the visibility of the product to private.
  2. Confirm the button "View product on store" is visible.

@Hicham, if the product visibility is private, "View product on store" button becomes invisible. Is the instruction wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: do not merge Dependent on another PR, ready for review but not ready for merge. type: enhancement A request for an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the Authenticated Webview implementation
4 participants