-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/13520 pos apply colors to home screen #13522
Open
malinajirka
wants to merge
12
commits into
feature-branch-woopos-design-system
Choose a base branch
from
issue/13520-pos-apply-colors-to-home-screen
base: feature-branch-woopos-design-system
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Issue/13520 pos apply colors to home screen #13522
malinajirka
wants to merge
12
commits into
feature-branch-woopos-design-system
from
issue/13520-pos-apply-colors-to-home-screen
+111
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
…ode' into issue/13520-pos-apply-colors-to-home-screen
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Base automatically changed from
13470-woo-posdesign-system-move-colors-from-ds-to-the-code
to
feature-branch-woopos-design-system
February 12, 2025 10:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: design
Layout and style elements in the UI or user interface, including color and animations.
feature: point of sale
POS project
status: do not merge
Dependent on another PR, ready for review but not ready for merge.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #13520
Do Not Merge - #13482 needs to be merged first.
NOTE - This PR updates only background colors and product placeholder. It doesn't update buttons, texts, spacing or Floating action button as those will be done in a separate PR.
Description
This PR introduces these changes:
surfaceDim
andsurfaceBright
color definitions to match the DS (they were swapped between dark and light mode).Testing information
Enter the POS and observe the updated designs of the home screen.
Open the ProductInfo dialog by clicking on the
info
icon and notice update colors of the dialog.The tests that have been performed
I've followed the above testing information.
Images/gif
[Shimmer Effect Animation](
https://github.com/user-attachments/assets/e5f44cd8-c334-4450-8e43-1e4a844e166f
)
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: