-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Shipping Label Revamp] Add Product Details UI #13600
base: trunk
Are you sure you want to change the base?
Conversation
…ctListItem UI usage
… TextField and different outline
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
...ce/android/ui/orders/wooshippinglabels/customs/products/WooShippingCustomsProductListItem.kt
Fixed
Show fixed
Hide fixed
...ce/android/ui/orders/wooshippinglabels/customs/products/WooShippingCustomsProductListItem.kt
Fixed
Show fixed
Hide fixed
...ce/android/ui/orders/wooshippinglabels/customs/products/WooShippingCustomsProductListItem.kt
Fixed
Show fixed
Hide fixed
...ce/android/ui/orders/wooshippinglabels/customs/products/WooShippingCustomsProductListItem.kt
Fixed
Show fixed
Hide fixed
Version |
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
<string name="woo_shipping_labels_customs_product_details_weight_per_unit">Weight per unit</string> | ||
<string name="woo_shipping_labels_customs_product_details_origin_country">Origin country</string> | ||
<string name="woo_shipping_labels_customs_product_details_origin_country_missing">Missing country</string> | ||
<string name="woo_shipping_labels_customs_product_details_origin_country_selection">Select a country</string> |
Check warning
Code scanning / Android Lint
Unused resources Warning
Summary
Partially fix issue #13367 by introducing the Product Details UI elements and the ShippingItems data from the main Creation form into the Customs form.
Upcoming PRs will add data validation and error handling.
Screen Capture
Screen_recording_20250225_215211.mp4
How to Test
In case you want to avoid having to fill the address data to access the Customs form, you can simply override the
ShouldRequireCustomsForm
use case always to return true to trigger the Customs data requirement forcefully.Update release notes:
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: