Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit order navigation #13613

Open
wants to merge 5 commits into
base: issue/12439-update-origin-address-errors
Choose a base branch
from

Conversation

atorresveiga
Copy link
Contributor

@atorresveiga atorresveiga commented Feb 22, 2025

Closes: #12439

Description

This PR fixes the edit origin address navigation. The changes introduced here add the Top bar navigation, the Close button navigation, and update the gesture navigation. I included a special case when using the gesture navigation: if the select address bottom sheet is expanded, then the back gesture navigation will close the bottom sheet; otherwise, it will navigate to the previous screen.

Testing information

TC1

  1. Open the orders tab
  2. Tap on an order eligible for shipping label creation
  3. Expand the shipment details section
  4. Expand the origin address selection (3 dots)
  5. Tap on the pencil
  6. Tap on the back arrow in the ToolBar
  7. Check that the app navigates to the previous screen

TC2

  1. Open the orders tab
  2. Tap on an order eligible for shipping label creation
  3. Expand the shipment details section
  4. Expand the origin address selection (3 dots)
  5. Tap on the pencil on a verified address
  6. Tap on the Close button
  7. Check that the app navigates to the previous screen

TC3

  1. Open the orders tab
  2. Tap on an order eligible for shipping label creation
  3. Expand the shipment details section
  4. Expand the origin address selection (3 dots)
  5. Tap on the pencil
  6. Update the postal code to make the address unverified
  7. Tap on validate and save
  8. Check that the address selection bottom sheet is expanded
  9. Use the back gesture/back navigation button
  10. Check that the address selection bottom sheet is collapsed
  11. Use the back gesture/back navigation button again to exit the screen (If an edit text field is focused, using the back button will first remove the focus and then navigate back)

The tests that have been performed

  • The tests described above

Images/gif

Screen_recording_20250224_072340.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@atorresveiga atorresveiga changed the base branch from trunk to issue/12439-update-origin-address-errors February 22, 2025 00:30
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Feb 22, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit1a001c2
Direct Downloadwoocommerce-wear-prototype-build-pr13613-1a001c2.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Feb 22, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit1a001c2
Direct Downloadwoocommerce-prototype-build-pr13613-1a001c2.apk

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 38.08%. Comparing base (1e8817c) to head (1a001c2).

Files with missing lines Patch % Lines
...s/address/origin/WooShippingEditOriginViewModel.kt 75.00% 2 Missing ⚠️
Additional details and impacted files
@@                             Coverage Diff                             @@
##             issue/12439-update-origin-address-errors   #13613   +/-   ##
===========================================================================
  Coverage                                       38.08%   38.08%           
- Complexity                                       9063     9066    +3     
===========================================================================
  Files                                            2058     2058           
  Lines                                          112708   112716    +8     
  Branches                                        14284    14286    +2     
===========================================================================
+ Hits                                            42922    42928    +6     
- Misses                                          65884    65886    +2     
  Partials                                         3902     3902           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atorresveiga atorresveiga added feature: shipping labels Related to creating, ordering, or printing shipping labels. type: task An internally driven task. labels Feb 24, 2025
@atorresveiga atorresveiga added this to the 21.9 milestone Feb 24, 2025
@atorresveiga atorresveiga marked this pull request as ready for review February 24, 2025 13:25
@ThomazFB ThomazFB self-assigned this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: shipping labels Related to creating, ordering, or printing shipping labels. type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit origin address UI
4 participants