-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit order navigation #13613
Open
atorresveiga
wants to merge
5
commits into
issue/12439-update-origin-address-errors
Choose a base branch
from
issue/12439-edit-order-navigation
base: issue/12439-update-origin-address-errors
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Edit order navigation #13613
atorresveiga
wants to merge
5
commits into
issue/12439-update-origin-address-errors
from
issue/12439-edit-order-navigation
+119
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## issue/12439-update-origin-address-errors #13613 +/- ##
===========================================================================
Coverage 38.08% 38.08%
- Complexity 9063 9066 +3
===========================================================================
Files 2058 2058
Lines 112708 112716 +8
Branches 14284 14286 +2
===========================================================================
+ Hits 42922 42928 +6
- Misses 65884 65886 +2
Partials 3902 3902 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature: shipping labels
Related to creating, ordering, or printing shipping labels.
type: task
An internally driven task.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #12439
Description
This PR fixes the edit origin address navigation. The changes introduced here add the Top bar navigation, the Close button navigation, and update the gesture navigation. I included a special case when using the gesture navigation: if the select address bottom sheet is expanded, then the back gesture navigation will close the bottom sheet; otherwise, it will navigate to the previous screen.
Testing information
TC1
TC2
TC3
The tests that have been performed
Images/gif
Screen_recording_20250224_072340.mp4
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: