Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woo POS] Add setting option to enable/disable Cha-Ching sound in POS #13809

Draft
wants to merge 9 commits into
base: issue/13636-play-cha-ching-sound-on-successfull-payment-pos
Choose a base branch
from

Conversation

AnirudhBhat
Copy link
Contributor

@AnirudhBhat AnirudhBhat commented Mar 19, 2025

Closes: #13804

NOTE: This PR depends on another parent PR. Please merge only after the parent PR has been merged.

Description

This PR gives merchants an ability to enable/disable the Cha-Ching sound on successful payment. The option is preserved in shared preference and hence it is remembered until the user signs out or uninstalls the app.

NOTE: Please note that the design and the placement of the setting is not optimal and needs design consideration before merging the code. I worked on this as a part of HACK week to demonstrate the feature. This can be merged only after we finalise the placement of the setting and designs.

Steps to reproduce

  1. Navigate to POS mode (more menu -> POS)
  2. Ensure you see an option to enable/disable Cha-Ching sound from the popup menu
  3. Enable the setting and make sure you hear Cha-Ching sound on successful payment
  4. Disable the setting and make sure you do not hear Cha-Ching sound on successful payment

The tests that have been performed

Tested above steps on both emulator and on tablet device

Images/gif

cha_ching_sound.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@AnirudhBhat AnirudhBhat added type: enhancement A request for an enhancement. needs: design Requires design input/work from a designer. status: do not merge Dependent on another PR, ready for review but not ready for merge. feature: point of sale POS project labels Mar 19, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Mar 19, 2025

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Mar 19, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitf4aef71
Direct Downloadwoocommerce-wear-prototype-build-pr13809-f4aef71.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Mar 19, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitf4aef71
Direct Downloadwoocommerce-prototype-build-pr13809-f4aef71.apk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: point of sale POS project needs: design Requires design input/work from a designer. status: do not merge Dependent on another PR, ready for review but not ready for merge. type: enhancement A request for an enhancement. unit-tests-exemption
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants