-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Woo POS] Add setting option to enable/disable Cha-Ching sound in POS #13809
Draft
AnirudhBhat
wants to merge
9
commits into
issue/13636-play-cha-ching-sound-on-successfull-payment-pos
Choose a base branch
from
issue/13804-toggle-cha-ching-sound-pos
base: issue/13636-play-cha-ching-sound-on-successfull-payment-pos
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[Woo POS] Add setting option to enable/disable Cha-Ching sound in POS #13809
AnirudhBhat
wants to merge
9
commits into
issue/13636-play-cha-ching-sound-on-successfull-payment-pos
from
issue/13804-toggle-cha-ching-sound-pos
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature: point of sale
POS project
needs: design
Requires design input/work from a designer.
status: do not merge
Dependent on another PR, ready for review but not ready for merge.
type: enhancement
A request for an enhancement.
unit-tests-exemption
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #13804
NOTE: This PR depends on another parent PR. Please merge only after the parent PR has been merged.
Description
This PR gives merchants an ability to enable/disable the Cha-Ching sound on successful payment. The option is preserved in shared preference and hence it is remembered until the user signs out or uninstalls the app.
NOTE: Please note that the design and the placement of the setting is not optimal and needs design consideration before merging the code. I worked on this as a part of HACK week to demonstrate the feature. This can be merged only after we finalise the placement of the setting and designs.
Steps to reproduce
The tests that have been performed
Tested above steps on both emulator and on tablet device
Images/gif
cha_ching_sound.mp4
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: