Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split shipment instructions #13828

Open
wants to merge 4 commits into
base: issue/13699-split-shipment-products-ui
Choose a base branch
from

Conversation

atorresveiga
Copy link
Contributor

Closes: #13699

Description

This PR includes the instructions in the split shipment flow

Testing information

TC1

  1. Open the orders tab
  2. Tap on an order eligible for shipping label creation without a shipping address
  3. Tap on Create shipping label
  4. Check that the Split shipment button is visible
  5. Tap on Split shipment
  6. Check that instructions are displayed

The tests that have been performed

  • Checking the instructions are displayed when the split shipment screen is opened

Images/gif

Screen_recording_20250321_234504.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@atorresveiga atorresveiga added type: task An internally driven task. feature: shipping labels Related to creating, ordering, or printing shipping labels. labels Mar 22, 2025
@atorresveiga atorresveiga added this to the 22.1 milestone Mar 22, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Mar 22, 2025

1 Warning
⚠️ Class SplitShipmentMessage is missing tests, but unit-tests-exemption label was set to ignore this.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit8352280
Direct Downloadwoocommerce-wear-prototype-build-pr13828-8352280.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit8352280
Direct Downloadwoocommerce-prototype-build-pr13828-8352280.apk

import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.lazy.LazyColumn
import androidx.compose.foundation.lazy.items
import androidx.compose.foundation.shape.CornerSize
import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.material.Card

Check warning

Code scanning / Android Lint

material and material3 are separate, incompatible design system libraries Warning

Using a material import while also using the material3 library
import androidx.compose.material.Icon
import androidx.compose.material.IconButton
import androidx.compose.material.MaterialTheme

Check warning

Code scanning / Android Lint

material and material3 are separate, incompatible design system libraries Warning

Using a material import while also using the material3 library
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 59.09091% with 9 lines in your changes missing coverage. Please review.

Project coverage is 38.02%. Comparing base (52827a1) to head (8352280).

Files with missing lines Patch % Lines
...glabels/split/WooShippingSplitShipmentViewModel.kt 61.90% 6 Missing and 2 partials ⚠️
...rce/android/ui/compose/component/FeedbackDialog.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                            Coverage Diff                            @@
##             issue/13699-split-shipment-products-ui   #13828   +/-   ##
=========================================================================
  Coverage                                     38.02%   38.02%           
  Complexity                                     9220     9220           
=========================================================================
  Files                                          2074     2074           
  Lines                                        114693   114708   +15     
  Branches                                      14608    14606    -2     
=========================================================================
+ Hits                                          43607    43618   +11     
- Misses                                        67134    67138    +4     
  Partials                                       3952     3952           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: shipping labels Related to creating, ordering, or printing shipping labels. type: task An internally driven task. unit-tests-exemption
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants