[Jetpack Performance] Add local feature flag and enable app passwords for all endpoints #14544

hichamboushaba · 2025-09-01T09:20:20Z

Closes WOOMOB-1220

Description

This PR adds the following changes:

Refactors the handling of app passwords configuration, so instead of just supplying the ApplicationClientId to the DI, we now supply an implementation of ApplicationPasswordsConfiguration, this allows us to control whether the feature is enabled or not from the app module.
Add a feature flag and use it to enable the feature. We'll replace this with a remote feature flag.
Move the WooExperimentalNetwork logic to WooNetwork, and update it to use the new property of ApplicationPasswordsConfiguration.
Improve the logging of failures (wip for now, I'll revisit this to see if we need further improvements).

Steps to reproduce

Confirm the feature flag APP_PASSWORDS_FOR_JETPACK_SITES is enabled.
Use a way to inspect app network requests.
Open the app.
Make sure you are signed in using WordPress.com account.
Confirm the app is using app passwords (talking to the site directly using its URL, and authenticating using app passwords.
Disable the feature flag APP_PASSWORDS_FOR_JETPACK_SITES.
Re-open the app.
Confirm the app is using Jetpack proxy.

Testing information

The above steps should be enough.

The tests that have been performed

The above.

I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

dangermattic · 2025-09-01T09:21:08Z

	3 Warnings
⚠️	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️	Class `WooWearApplicationPasswordsConfiguration` is missing tests, but `unit-tests-exemption` label was set to ignore this.
⚠️	Class `WooApplicationPasswordsConfiguration` is missing tests, but `unit-tests-exemption` label was set to ignore this.

Generated by 🚫 Danger

wpmobilebot · 2025-09-01T09:40:34Z

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`586a357`
	Direct Download	`woocommerce-prototype-build-pr14544-586a357.apk`

hichamboushaba · 2025-09-01T18:53:28Z

WooCommerce-Wear/src/main/java/com/woocommerce/android/wear/di/ApplicationPasswordsModule.kt

+    override fun isEnabledForDirectAccess(): Boolean = false
+    override suspend fun isEnabledForJetpackAccess(): Boolean = false


The wear app didn't support Application Passwords before #12124, and we are keeping the same behavior.

hichamboushaba · 2025-09-01T18:57:03Z

...s/android/fluxc/network/rest/wpapi/applicationpasswords/ApplicationPasswordsConfiguration.kt

+     * Returns true if the Application Passwords feature is enabled for Jetpack-mediated access.
+     * This applies when sites are accessed through Jetpack, even if they are self-hosted.
+     */
+    suspend fun isEnabledForJetpackAccess(): Boolean


Having this a suspendable function will make using remote feature flags easier for us, given they require DB access.

wpmobilebot · 2025-09-01T18:59:52Z

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`586a357`
	Direct Download	`woocommerce-wear-prototype-build-pr14544-586a357.apk`

codecov-commenter · 2025-09-01T20:07:29Z

Codecov Report

❌ Patch coverage is 8.57143% with 96 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.32%. Comparing base (c58946a) to head (586a357).
⚠️ Report is 25 commits behind head on trunk.

Files with missing lines	Patch %	Lines
.../android/fluxc/network/rest/wpcom/wc/WooNetwork.kt	0.00%	60 Missing ⚠️
.../org/wordpress/android/fluxc/store/WCOrderStore.kt	0.00%	12 Missing ⚠️
...uxc/network/rest/wpcom/wc/order/OrderRestClient.kt	14.28%	6 Missing ⚠️
...npasswords/WooApplicationPasswordsConfiguration.kt	0.00%	5 Missing ⚠️
...erce/android/wear/di/ApplicationPasswordsModule.kt	0.00%	4 Missing ⚠️
...rc/main/kotlin/com/woocommerce/android/AppPrefs.kt	0.00%	4 Missing ⚠️
.../android/ui/orders/list/OrderListItemDataSource.kt	0.00%	2 Missing ⚠️
...kotlin/com/woocommerce/android/util/FeatureFlag.kt	66.66%	1 Missing ⚠️
...tionpasswords/ApplicationPasswordsConfiguration.kt	0.00%	1 Missing ⚠️
.../applicationpasswords/ApplicationPasswordsStore.kt	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##              trunk   #14544      +/-   ##
============================================
+ Coverage     38.31%   38.32%   +0.01%     
+ Complexity     9645     9641       -4     
============================================
  Files          2051     2052       +1     
  Lines        114860   114813      -47     
  Branches      15240    15239       -1     
============================================
- Hits          44011    44005       -6     
+ Misses        66816    66776      -40     
+ Partials       4033     4032       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

hichamboushaba · 2025-09-02T10:28:35Z

libs/fluxc/src/main/java/org/wordpress/android/fluxc/model/SiteModel.java


    public boolean isUsingWpComRestApi() {
-        return isWPCom() || (isJetpackConnected() && getOrigin() == ORIGIN_WPCOM_REST);
+        return isWPCom() || getOrigin() == ORIGIN_WPCOM_REST;


When testing the app passwords feature with a Jetpack CP site, I found an issue, we always ignore the created password, and the cause was in this condition.
I checked the usages of this function, and I think we can safely remove the Jetpack connection condition here, as they apply also to Jetpack CP sites.

This gives the clients more freedom in enabling disabling features, which will allow us to control the feature using remote feature flag.

…om login

- Renames the functions for better clarity. - Make `isEnabledForJetpackAccess` suspendable to be ready for remote feature flag access

`isUsingWpComRestApi` was returning false for Jetpack CP sites, leading to always ignoring saved app passwords credentials, as for WPCom rest sites, `SiteModel#username` is always null.

hichamboushaba · 2025-09-02T18:13:02Z

...fluxc-plugin/src/main/kotlin/org/wordpress/android/fluxc/network/rest/wpcom/wc/WooNetwork.kt

 * The [SiteModel.ORIGIN_XMLRPC] support is kept for backward compatibility
 */
 @Singleton
 class WooNetwork @Inject constructor(


All the changes here are a copy of what we had before in WooExperimentalNetwork

To match iOS platform

hichamboushaba · 2025-09-04T12:33:11Z

@irfano since Jorge is AFK for two days, I'm removing his assignment for this PR.
Reviewing this is not urgent, but if you have some time you'll have something to review, and this is a base for my other PRs, so having it merged before them will make things easier for me.

irfano

It works expected. I also tested the Wear app, it works there as well. I'm approving but not merging in case you'd like to make changes based on these notes:

In WPAPIResponse, there's this comment: "This is used for tracking purposes, and used only with the Woo experimental networking mode." I believe this is no longer valid and can be removed.
I believe the fetchAppPasswordsSupportIfNeeded() function is no longer needed and can be removed.

irfano · 2025-09-04T21:23:23Z

...fluxc-plugin/src/main/kotlin/org/wordpress/android/fluxc/network/rest/wpcom/wc/WooNetwork.kt

+            "Request failed using Application Passwords for Jetpack Site,\n" +
+                "site: ${siteUrl},\n" +
+                "path: ${requestContext.path},\n" +
+                "method: ${requestContext.method},\n" +
+                "error: HTTP status code ${error.volleyError.networkResponse?.statusCode}, " +
+                "error message: ${error.errorCode?.ifEmpty { null } ?: error.message}",


Nice logging details, they’ll be helpful for debugging. 👍🏻

…asswords-toggle [Jetpack Performance] Add a preference toggle for enabling app passwords for Jetpack sites

# Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/AppPrefs.kt

hichamboushaba · 2025-09-05T21:31:22Z

Thanks @irfano, both remarks are addressed, nice catch.

hichamboushaba added type: task An internally driven task. category: performance Related to performance such as slow loading. labels Sep 1, 2025

hichamboushaba added the unit-tests-exemption label Sep 1, 2025

hichamboushaba force-pushed the issue/WOOMOB-1126-app-passwords-network branch from 0e380bc to 2792941 Compare September 1, 2025 18:34

hichamboushaba commented Sep 1, 2025

View reviewed changes

hichamboushaba requested review from JorgeMucientes and irfano September 1, 2025 18:56

hichamboushaba marked this pull request as ready for review September 1, 2025 18:56

hichamboushaba commented Sep 1, 2025

View reviewed changes

hichamboushaba added this to the 23.2 milestone Sep 1, 2025

hichamboushaba force-pushed the issue/WOOMOB-1126-app-passwords-network branch from ae981cd to b43d54c Compare September 1, 2025 19:53

hichamboushaba commented Sep 2, 2025

View reviewed changes

hichamboushaba added 14 commits September 2, 2025 19:11

Refactor handling of Application Passwords configuration

9789e81

This gives the clients more freedom in enabling disabling features, which will allow us to control the feature using remote feature flag.

Rename property

6161d74

Add new property to control whether feature is enabled or not for WPC…

cb1cf6e

…om login

Copy WooExperimentalNetwork logic to WooNetwork

225395d

Remove WooExperimentalNetwork

856bbe1

Force using Jetpack tunnel when feature is disabled

3444de8

Remove unused argument

aeb3d6b

Remove unused remote config key

7df9071

Remove old code related to the initial experiment

65d2f19

Improve log message for failed requests

edc6d45

Add a feature flag for the feature

90d18fb

Minor refactoring for the configuration class

a442412

- Renames the functions for better clarity. - Make `isEnabledForJetpackAccess` suspendable to be ready for remote feature flag access

Make isEnabledForDirectAccess enabled by default

60312f7

Update unit tests

043d3dc

hichamboushaba added 3 commits September 2, 2025 19:11

Fix detekt issues

de41eb5

Fix wear app build issue

c7f9c85

Fix issue for Jetpack CP sites

8ea3d7f

`isUsingWpComRestApi` was returning false for Jetpack CP sites, leading to always ignoring saved app passwords credentials, as for WPCom rest sites, `SiteModel#username` is always null.

hichamboushaba force-pushed the issue/WOOMOB-1126-app-passwords-network branch from 06cffda to 8ea3d7f Compare September 2, 2025 18:11

hichamboushaba commented Sep 2, 2025

View reviewed changes

hichamboushaba added 3 commits September 3, 2025 11:36

Add preference key for the experimental toggle

bd77057

Add a preference toggle to the experimental features screen

44044c9

Rename settings entry to "Experimental features"

2ef0b44

To match iOS platform

JorgeMucientes self-assigned this Sep 3, 2025

hichamboushaba unassigned JorgeMucientes Sep 4, 2025

irfano self-assigned this Sep 4, 2025

irfano approved these changes Sep 4, 2025

View reviewed changes

irfano modified the milestones: 23.2, 23.3 Sep 5, 2025

irfano and others added 4 commits September 5, 2025 16:34

Merge pull request #14559 from woocommerce/issue/WOOMOB-1183-jp-app-p…

1700937

…asswords-toggle [Jetpack Performance] Add a preference toggle for enabling app passwords for Jetpack sites

Remove outdated comment section

8ee5125

Merge branch 'trunk' into issue/WOOMOB-1126-app-passwords-network

3e845a0

# Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/AppPrefs.kt

Remove old way for checking for app passwords support

586a357

hichamboushaba enabled auto-merge September 5, 2025 21:30

hichamboushaba merged commit adfdc06 into trunk Sep 5, 2025
17 checks passed

hichamboushaba deleted the issue/WOOMOB-1126-app-passwords-network branch September 5, 2025 22:12

		override fun isEnabledForDirectAccess(): Boolean = false
		override suspend fun isEnabledForJetpackAccess(): Boolean = false

[Jetpack Performance] Add local feature flag and enable app passwords for all endpoints #14544

[Jetpack Performance] Add local feature flag and enable app passwords for all endpoints #14544

Uh oh!

Conversation

hichamboushaba commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Steps to reproduce

Testing information

The tests that have been performed

Uh oh!

dangermattic commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hichamboushaba Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hichamboushaba Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

wpmobilebot commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hichamboushaba Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

hichamboushaba Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

hichamboushaba commented Sep 4, 2025

Uh oh!

irfano left a comment

Choose a reason for hiding this comment

Uh oh!

irfano Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

hichamboushaba commented Sep 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

hichamboushaba commented Sep 1, 2025 •

edited

Loading

dangermattic commented Sep 1, 2025 •

edited

Loading

wpmobilebot commented Sep 1, 2025 •

edited

Loading

hichamboushaba Sep 1, 2025 •

edited

Loading

wpmobilebot commented Sep 1, 2025 •

edited

Loading

codecov-commenter commented Sep 1, 2025 •

edited

Loading