Skip to content

Conversation

@kidinov
Copy link
Contributor

@kidinov kidinov commented Sep 3, 2025

WOOMOB-1256

Description

Removed feature flags that were permanently set to true and their associated dead code. This cleanup removes unused conditional logic from the codebase.

Steps to reproduce

No user-facing changes. The removed feature flags were:

  • NEW_SHIPPING_SUPPORT,
  • BULK_UPDATE_ORDERS_STATUS,
  • HIDE_SITES_FROM_SITE_PICKER,
  • REVAMP_WOO_SHIPPING -> true

Testing information

Green CI should be enouph

Images/gif

No UI changes.

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@kidinov kidinov marked this pull request as ready for review September 3, 2025 11:37
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 3, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit90cf276
Direct Downloadwoocommerce-wear-prototype-build-pr14555-90cf276.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 3, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit90cf276
Direct Downloadwoocommerce-prototype-build-pr14555-90cf276.apk

@kidinov kidinov added this to the 23.2 milestone Sep 3, 2025
@wpmobilebot wpmobilebot modified the milestones: 23.2, 23.3 Sep 5, 2025
@wpmobilebot
Copy link
Collaborator

Version 23.2 has now entered code-freeze, so the milestone of this PR has been updated to 23.3.

@kidinov kidinov requested a review from samiuelson September 8, 2025 08:54
Copy link
Contributor

@JorgeMucientes JorgeMucientes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this cleanup @kidinov 🙏🏼
Code changes look good to me 👍🏼

@JorgeMucientes JorgeMucientes self-assigned this Sep 8, 2025
…-with-the-dead-code

# Conflicts:
#	WooCommerce/src/main/kotlin/com/woocommerce/android/util/FeatureFlag.kt
@kidinov kidinov enabled auto-merge September 8, 2025 14:16
@kidinov kidinov merged commit 3d6edae into trunk Sep 8, 2025
18 checks passed
@kidinov kidinov deleted the woomob-1256-tech-debt-remove-ff-set-to-true-with-the-dead-code branch September 8, 2025 14:50
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.30%. Comparing base (f8e2fd7) to head (90cf276).
⚠️ Report is 3 commits behind head on trunk.

Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #14555      +/-   ##
============================================
- Coverage     38.30%   38.30%   -0.01%     
+ Complexity     9647     9644       -3     
============================================
  Files          2054     2054              
  Lines        114929   114920       -9     
  Branches      15246    15243       -3     
============================================
- Hits          44025    44016       -9     
- Misses        66874    66876       +2     
+ Partials       4030     4028       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants