-
Notifications
You must be signed in to change notification settings - Fork 136
[WOOMOB-1256] Remove unused feature flags and associated dead code #14555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WOOMOB-1256] Remove unused feature flags and associated dead code #14555
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
|
Version |
JorgeMucientes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing this cleanup @kidinov 🙏🏼
Code changes look good to me 👍🏼
…-with-the-dead-code # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/util/FeatureFlag.kt
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #14555 +/- ##
============================================
- Coverage 38.30% 38.30% -0.01%
+ Complexity 9647 9644 -3
============================================
Files 2054 2054
Lines 114929 114920 -9
Branches 15246 15243 -3
============================================
- Hits 44025 44016 -9
- Misses 66874 66876 +2
+ Partials 4030 4028 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WOOMOB-1256
Description
Removed feature flags that were permanently set to true and their associated dead code. This cleanup removes unused conditional logic from the codebase.
Steps to reproduce
No user-facing changes. The removed feature flags were:
Testing information
Green CI should be enouph
Images/gif
No UI changes.
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.