POS Product Migration Step 5 #14588
Merged
POS Product Migration Step 5 #14588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
…omob-1280-woo-poslocal-catalog-use-new-pos-specific-product-model # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/common/data/searchbyidentifier/WooPosSearchByIdentifier.kt # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/common/data/searchbyidentifier/WooPosSearchByIdentifierResult.kt
kidinov
reviewed
Sep 8, 2025
| @@ -0,0 +1,31 @@ | |||
| package com.woocommerce.android.ui.woopos.util | |||
Contributor
There was a problem hiding this comment.
Should we name the file with “test” in it to avoid cluttering the main namespace when searching for products-related files in the production code? WooPosProductTestUtil maybe
Contributor
Author
There was a problem hiding this comment.
Good idea, I've done this in the last PR in the chain - 44471ed.
kidinov
approved these changes
Sep 8, 2025
Contributor
kidinov
left a comment
kidinov
left a comment
There was a problem hiding this comment.
LGTM! A lot of nice ideas with this model 👏
I left one np - feel free to merge!
malinajirka
merged commit f4b5bc3
into
feature-branch-for-pos-product-migration
12 of 18 checks passed
malinajirka
deleted the
issue/woomob-1280-woo-poslocal-catalog-use-new-pos-specific-product-model
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing CI is expected here since this is a partial migration.
Description
This is part of the migration to POS specific Product Model. There will be many changes and I want to avoid huge PRs. Therefore I created a feature branch - I'll create a PR for each set of changes. The CI won't be able to build this PR, but I personally wouldn't worry about it -> we can ensure everything is green and working as expected when we are merging the feature branch back to trunk.
The
Version2in the name WooPosProductModelVersion2 will eventually be removed.This PR migrates WooPosProductsViewModel and a couple search related classes.
Images/gif
N/A
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.