POS Product Migration Step 6 #14589
Merged
POS Product Migration Step 6 #14589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malinajirka
added
status: do not merge
Collaborator
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
…ific-product-model' into issue/woomob-1280-woo-poslocal-catalog-use-new-pos-specific-product-model-step-6 # Conflicts: # WooCommerce/src/test/kotlin/com/woocommerce/android/ui/woopos/common/data/searchbyidentifier/WooPosSearchByIdentifierProcessVariationResultTest.kt # WooCommerce/src/test/kotlin/com/woocommerce/android/ui/woopos/common/data/searchbyidentifier/WooPosSearchByIdentifierResultConverterTest.kt
Base automatically changed from
issue/woomob-1280-woo-poslocal-catalog-use-new-pos-specific-product-model
to
feature-branch-for-pos-product-migration
September 9, 2025 06:35
…omob-1280-woo-poslocal-catalog-use-new-pos-specific-product-model-step-6
malinajirka
removed
the
status: do not merge
kidinov
reviewed
Sep 9, 2025
| is WooPosSearchByIdentifierResult.Success -> { | ||
| val product = result.product | ||
| if (product.type.equals("variation", ignoreCase = true)) { | ||
| if (product.type.value.equals("variation", ignoreCase = true)) { |
Contributor
There was a problem hiding this comment.
Shell it be product.type == WooPosProductModelVersion2.WooPosProductType.VARIATION ?
kidinov
reviewed
Sep 9, 2025
| updatedItem: WooPosCartItemViewState.Product, | ||
| updatedProduct: ParentToChildrenEvent.OrderCreated.ProductInfo | ||
| ) { | ||
| // TBD Local Catalog The app should update cache based on the data coming from backend not from the view layer |
Contributor
There was a problem hiding this comment.
Is the data coming here from the view layer?
Contributor
Author
There was a problem hiding this comment.
Yes, or at least we are receiving WooPosCartItemViewState.Product which is a ViewState.
kidinov
approved these changes
Sep 9, 2025
Contributor
kidinov
left a comment
kidinov
left a comment
There was a problem hiding this comment.
LGTM! I left a couple of minor comments here
malinajirka
merged commit 0e38476
into
feature-branch-for-pos-product-migration
4 of 5 checks passed
malinajirka
deleted the
issue/woomob-1280-woo-poslocal-catalog-use-new-pos-specific-product-model-step-6
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 5 needs to be merged first.
Failing CI is expected here since this is a partial migration.
Description
This is part of the migration to POS specific Product Model. There will be many changes and I want to avoid huge PRs. Therefore I created a feature branch - I'll create a PR for each set of changes. The CI won't be able to build this PR, but I personally wouldn't worry about it -> we can ensure everything is green and working as expected when we are merging the feature branch back to trunk.
The
Version2in the name WooPosProductModelVersion2 will eventually be removed.This PR migrates WooPosCartItemsUpdater, WooPosSearchByIdentifierProcessVariationResult and WooPosSearchByIdentifierResultConverter.
Images/gif
N/A
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.