POS Product Migration Step 7 #14590
POS Product Migration Step 7 #14590
Conversation
malinajirka
added
status: do not merge
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
| on { events }.thenReturn(parentToChildrenMutableSharedFlow) | ||
| } | ||
|
|
||
| private val mockedEventForTracking: WooPosAnalyticsEvent.Event.ItemAddedToCart = |
There was a problem hiding this comment.
I’m curious, why do we need this one? And if we do, why is it called “mocked” when it seems to be the real object?
There was a problem hiding this comment.
Detekt wouldn't let me keep the mocked data object - there is a relatively new rule, that data classes can't be mocked. I kept the word mocked in the name to highlight, the object is kind of random - isn't actually testing which event we are passing/getting, just that it's a WooPosAnalyticsEvent.
kidinov
left a comment
kidinov
left a comment
There was a problem hiding this comment.
LGTM! I made a comment about the changes in the test
| ) : Parcelable { | ||
|
|
||
| val variationEnabledAttributes | ||
| get() = attributes.filter { it.isVariation } |
There was a problem hiding this comment.
It's an immutable data class, so do we need to refilter the list every time when it's accessed, or maybe it will be more efficient to have it as a field?
@IgnoredOnParcel
val variationEnabledAttributes = attributes.filter { it.isVariation }
?
There was a problem hiding this comment.
Good point, I'll create a lazily calculated property - that gives us the best of both worlds.
…ific-product-model-step-6' into issue/woomob-1280-woo-poslocal-catalog-use-new-pos-specific-product-model-step-7
malinajirka
removed
the
status: do not merge
malinajirka
merged commit 07ee3f6
into
feature-branch-for-pos-product-migration
malinajirka
deleted the
issue/woomob-1280-woo-poslocal-catalog-use-new-pos-specific-product-model-step-7
branch
Step 6 needs to be merged first.
Failing CI is expected here since this is a partial migration.
Description
This is part of the migration to POS specific Product Model. There will be many changes and I want to avoid huge PRs. Therefore I created a feature branch - I'll create a PR for each set of changes. The CI won't be able to build this PR, but I personally wouldn't worry about it -> we can ensure everything is green and working as expected when we are merging the feature branch back to trunk.
The
Version2in the name WooPosProductModelVersion2 will eventually be removed.This PR migrates WooPosCartViewModel, WooPosVariationMapper, WooPosProductSearchPredicate, WooPosSearchProductsDataSource,WooPosSearchResultsIndex
Images/gif
N/A
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.