Skip to content

Conversation

@malinajirka
Copy link
Contributor

@malinajirka malinajirka commented Sep 9, 2025

Step 8 needs to be merged first.

Description

This is the final part of the migration to POS specific Product Model. This PR should be thoroughly tested, since the previous PRs weren't mergable, hence couldn't be tested.

There are two changes made in this PR

  • The version2 suffix is removed from the name.
  • Unit tests are updated and fixed.

To Test

  • Verify only simple and variable products are visible
  • Verify downloadable products are NOT visible
  • Verify all expected variations are displayed
  • Verify prices are correct - sale vs regular
  • Add a product to the cart, change its price on the backend, move to checkout and verify the price is updated
  • Verify search works as expected
  • Verify barcode scanning works

Images/gif

N/A - no user facing changes.

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@malinajirka malinajirka requested a review from kidinov September 9, 2025 07:20
@malinajirka malinajirka added this to the 23.3 milestone Sep 9, 2025
@malinajirka malinajirka changed the base branch from trunk to issue/woomob-1280-woo-poslocal-catalog-use-new-pos-specific-product-model-step-8 September 9, 2025 07:21
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 9, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitb511ac7
Direct Downloadwoocommerce-wear-prototype-build-pr14594-b511ac7.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 9, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitb511ac7
Direct Downloadwoocommerce-prototype-build-pr14594-b511ac7.apk

@malinajirka malinajirka marked this pull request as draft September 9, 2025 11:35
@malinajirka malinajirka marked this pull request as ready for review September 9, 2025 12:29
private val productStore: WCProductStore = mock()
private val site: SiteModel = mock()
private val wooPosLogWrapper: WooPosLogWrapper = mock()
private val posProductMapper: WCProductToWooPosProductModelMapper = mock()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed that this class is still supposed to be called with the WooPos prefix - WooPosWCProductToWooPosProductModelMapper

Copy link
Contributor

@kidinov kidinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from issue/woomob-1280-woo-poslocal-catalog-use-new-pos-specific-product-model-step-8 to feature-branch-for-pos-product-migration September 10, 2025 12:49
@malinajirka malinajirka merged commit a44701e into feature-branch-for-pos-product-migration Sep 10, 2025
4 of 6 checks passed
@malinajirka malinajirka deleted the issue/woomob-1280-woo-poslocal-catalog-use-new-pos-specific-product-model-step-9 branch September 10, 2025 12:58
@malinajirka malinajirka mentioned this pull request Sep 10, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants