-
Notifications
You must be signed in to change notification settings - Fork 136
POS Product Migration Step 9 - final step #14594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POS Product Migration Step 9 - final step #14594
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
| private val productStore: WCProductStore = mock() | ||
| private val site: SiteModel = mock() | ||
| private val wooPosLogWrapper: WooPosLogWrapper = mock() | ||
| private val posProductMapper: WCProductToWooPosProductModelMapper = mock() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed that this class is still supposed to be called with the WooPos prefix - WooPosWCProductToWooPosProductModelMapper
kidinov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
a44701e
into
feature-branch-for-pos-product-migration
Step 8 needs to be merged first.
Description
This is the final part of the migration to POS specific Product Model. This PR should be thoroughly tested, since the previous PRs weren't mergable, hence couldn't be tested.
There are two changes made in this PR
version2suffix is removed from the name.To Test
Images/gif
N/A - no user facing changes.
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.