Skip to content

Conversation

@AdamGrzybkowski
Copy link
Contributor

Closes WOOMOB-445

Description

When testing 22.2 two UI glitches were found:

Loading Spinner cut off when opening shipping class

Fix by replacing the bottom margin with a vertical margin to keep it symetrical.

Before After
Screenshot_20250912_114911 Screenshot_20250912_115232

Wrong skeletons color in the Plugins screen

The custom composable used a fixed color there. After looking around, I noticed there's a SkeletonView for such a scenario, so I replaced the custom one with it completely. This should ensure the shimmer effect is consistent across the screens.

Before After
shim_before shim_after
shim_light_before shim_light_after

Steps to reproduce / Testing information

Loading Spinner cut off when opening shipping class

  1. Make sure you have no shipping classes (this loading is shown only when the list is empty, otherwise cached values are used)
  2. Go to product
  3. Tap "Shipping" or if it's not there tap "Add more details"
  4. Tap "Shipping class"
  5. Observe the progress indicator

Wrong skeletons color in the Plugins screen

  1. Enable dark theme
  2. Go to "Settings"
  3. Tap "Installed plugins"
  4. Notice the shimmer effect color
  5. Switch theme and re-enter the screen to verify the shimmer again

The tests that have been performed

The above

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes two UI glitches found during testing: a loading spinner being cut off in the shipping class screen and incorrect skeleton colors in the plugins screen. The changes improve visual consistency and proper display of loading states.

  • Fixed loading spinner positioning by replacing bottom margin with vertical margin
  • Replaced custom shimmer implementation with standard SkeletonView component for consistent theming
  • Removed unnecessary animation and brush code from plugins screen

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
fragment_product_shipping_class_list.xml Updated progress bar margin to fix cut-off issue
PluginsScreen.kt Replaced custom shimmer implementation with SkeletonView component

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit26e4676
Direct Downloadwoocommerce-wear-prototype-build-pr14609-26e4676.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit26e4676
Direct Downloadwoocommerce-prototype-build-pr14609-26e4676.apk

Copy link
Member

@hichamboushaba hichamboushaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @AdamGrzybkowski :shipit:

@hichamboushaba hichamboushaba merged commit d682edd into trunk Sep 12, 2025
21 of 22 checks passed
@hichamboushaba hichamboushaba deleted the issue/WOOMOB-445_ui_glitches branch September 12, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants