-
Notifications
You must be signed in to change notification settings - Fork 136
[CIAB] Integrate the garden arch API and add a helper class for deciding features to be disabled for CIAB sites #14616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CIAB] Integrate the garden arch API and add a helper class for deciding features to be disabled for CIAB sites #14616
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
| public boolean single_user_site; | ||
| public List<String> jetpack_modules; | ||
| public boolean is_garden; | ||
| public String garden_name; |
Check notice
Code scanning / Android Lint
Nullable/NonNull annotation missing on field Note
| public List<String> jetpack_modules; | ||
| public boolean is_garden; | ||
| public String garden_name; | ||
| public String garden_partner; |
Check notice
Code scanning / Android Lint
Nullable/NonNull annotation missing on field Note
AdamGrzybkowski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Tested with the provided patch, but also checked the network responses and database table rows to confirm the values were set correctly.
I left a comment about the UI test failing. Approving because the test is missing a mock and the rest of the code works well.
WooCommerce/src/test/kotlin/com/woocommerce/android/ciab/CIABSiteGateKeeperTest.kt
Show resolved
Hide resolved
0acce60 to
d971bd9
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## trunk #14616 +/- ##
=========================================
Coverage 38.39% 38.40%
- Complexity 9724 9731 +7
=========================================
Files 2059 2061 +2
Lines 115273 115294 +21
Branches 15339 15340 +1
=========================================
+ Hits 44260 44275 +15
- Misses 66913 66917 +4
- Partials 4100 4102 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closes WOOMOB-1274
Description
This is the first PR for updating the app to allow adjusting the experience for CIAB sites, the PR introduces the following changes:
SiteModelDB table to include the new fields added for the garden architecture.CIABSiteGateKeeperclass for controlling which features we'll disable for CIAB sites.Note: The
CIABSiteGateKeeperandCIABAffectedFeaturearchitecture is modeled after what the iOS team did, just with different names. I think the architecture makes sense, even though we'll disable all features of the enumCIABAffectedFeatureinitially. Also, even though I'm not sure we'll ever need this, the flexibility could be helpful in the future if we need to offer different features to the different partners.For some context on the Garden Architecture, check this PdpAdu-2ai-p2
Steps to reproduce
For the
CIABSiteGateKeeperjust check the unit tests, as it's not used now.For the sites API
Patch
Testing information
The tests that have been performed
The above.
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.